Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JSON marshal tests for dependabot alerts #3480

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

raisa2010
Copy link
Contributor

@raisa2010 raisa2010 commented Feb 15, 2025

This PR adds some more tests for issue #55. Would appreciate a review!

Also noticed that some fields in the Github API response such as cvss_severities and epss are not supported in the existing struct. Is this expected (deprecated fields) or just new fields in the Github response that haven't been reflected in the current codebase yet?

Thanks in advance!

@raisa2010 raisa2010 force-pushed the feat/add-dependabot-alert-tests branch from d41dbb8 to db419fa Compare February 15, 2025 12:13
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (6c46d71) to head (d8eebc1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3480   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         179      179           
  Lines       15561    15561           
=======================================
  Hits        14165    14165           
  Misses       1223     1223           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 15, 2025

Also noticed that some fields in the Github API response such as cvss_severities and epss are not supported in the existing struct. Is this expected (deprecated fields) or just new fields in the Github response that haven't been reflected in the current codebase yet?

There are several possibilities, and I would have to look up those specific cases to answer your question but don't have time at the moment. We rarely remove fields but do try to mark them as deprecated if indeed they are. Most of the time, they are added by GitHub after our endpoints are written. When someone needs them, we add a PR.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @raisa2010.
LGTM.
Merging.

@gmlewis gmlewis merged commit 81dc7a9 into google:master Feb 15, 2025
7 checks passed
@raisa2010
Copy link
Contributor Author

Got it, thank you for clarifying and reviewing @gmlewis!

@raisa2010 raisa2010 deleted the feat/add-dependabot-alert-tests branch February 15, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants