Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-accessors: update dumping of getters #3437

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 16, 2025

After merging this PR, the checks for #3433 will become green (I checked here).

The PR addresses the issue described in #3433 (comment): we need to guarantee the order of equal getters.

func (s *SMTP) GetUsername() string {
	if s == nil || s.Username == nil {
		return ""
	}
	return *s.Username
}

// GetUserName returns the UserName field if it's non-nil, zero value otherwise.
func (s *SMTP) GetUserName() string {
	if s == nil || s.UserName == nil {
		return ""
	}
	return *s.UserName
}

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (ec4431e).
Report is 223 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3437      +/-   ##
==========================================
- Coverage   97.72%   92.26%   -5.46%     
==========================================
  Files         153      174      +21     
  Lines       13390    15023    +1633     
==========================================
+ Hits        13085    13861     +776     
- Misses        215     1068     +853     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

@gmlewis gmlewis merged commit d13c739 into google:master Jan 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants