Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing notification_setting to Team #3431

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

stevehipwell
Copy link
Contributor

This PR adds the missing notification_setting field from the Team type (it was already present in NewTeam).

@gmlewis gmlewis changed the title feat: Added missing notification_setting from team feat: Add missing notification_setting from team Jan 14, 2025
@gmlewis gmlewis changed the title feat: Add missing notification_setting from team feat: Add missing notification_setting to team Jan 14, 2025
@stevehipwell
Copy link
Contributor Author

I've fixed the failing tests, the notification_setting were being returned in a test that wasn't using them until now.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell !
LGTM.

Merging after tests pass.

@gmlewis gmlewis changed the title feat: Add missing notification_setting to team feat: Add missing notification_setting to Team Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (28d216b).
Report is 221 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
- Coverage   97.72%   92.26%   -5.46%     
==========================================
  Files         153      174      +21     
  Lines       13390    15023    +1633     
==========================================
+ Hits        13085    13861     +776     
- Misses        215     1068     +853     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis merged commit 6b18a2b into google:master Jan 14, 2025
6 of 7 checks passed
@stevehipwell stevehipwell deleted the add-team-notification-setting branch January 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants