-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support in rulesets for including or excluding repos based on properties #3194
Add support in rulesets for including or excluding repos based on properties #3194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3194 +/- ##
==========================================
- Coverage 97.72% 92.90% -4.82%
==========================================
Files 153 171 +18
Lines 13390 11548 -1842
==========================================
- Hits 13085 10729 -2356
- Misses 215 726 +511
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @claystation !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gmlewis i had to fix a small bug by removing |
Thank you, @ysoldak and @claystation ! |
Github recently introduced Repository Properties. Rulesets can include or exclude repositories based on these properties.
The PR implements those conditions.
According to Github API docs:
https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28#create-an-organization-repository-ruleset
Changed comment on
RulesetConditions
struct to say either use Name, ID OR repo property. The docs have not been super clear on this but i assume so because when creating rulesets trough UI you can either select repositories based on name or on property.Please let me know what you think!