Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scrape apps to google-go v39 #2121

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

chmouel
Copy link
Contributor

@chmouel chmouel commented Oct 8, 2021

While it's possible, this cause confusion when we want to use the "scrape" library with githubv39 and having to import v32.

Bumping it to latest,

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #2121 (29895c1) into master (f664094) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2121   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         112      112           
  Lines        9956     9956           
=======================================
  Hits         9735     9735           
  Misses        154      154           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f664094...29895c1. Read the comment docs.

@chmouel chmouel force-pushed the scrape-update-to-v35 branch from 318790e to 64b1dc7 Compare October 8, 2021 06:22
@chmouel chmouel changed the title Bump scrape apps to google-go v35 Bump scrape apps to google-go v39 Oct 8, 2021
Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the scrape-update-to-v35 branch from 64b1dc7 to 29895c1 Compare October 8, 2021 06:23
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 8, 2021

At one point, @willnorris asked me to keep the versions separate, so I defer to him on this one.

@gmlewis gmlewis requested a review from willnorris October 8, 2021 11:04
@willnorris
Copy link
Collaborator

At one point, @willnorris asked me to keep the versions separate, so I defer to him on this one.

I think I probably just meant to keep the the scrape package in its own go module that is versioned independently. Bumping the version of go-github/github like this should always be fine.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 8, 2021

At one point, @willnorris asked me to keep the versions separate, so I defer to him on this one.

I think I probably just meant to keep the the scrape package in its own go module that is versioned independently. Bumping the version of go-github/github like this should always be fine.

Thank you, @willnorris !
LGTM.
Merging.

@gmlewis gmlewis merged commit 6b0f37f into google:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants