-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use x crypto instead of sodium #2034
Use x crypto instead of sodium #2034
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2034 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 107 107
Lines 6907 6907
=======================================
Hits 6760 6760
Misses 81 81
Partials 66 66 Continue to review full report at Codecov.
|
Yes, please add a new example and distinguish between the two with pros/cons in a comment if you wish. The |
d63d228
to
b98fd4b
Compare
b98fd4b
to
0fe4df8
Compare
@gmlewis I pushed it as a new directory, but I didn't change the name of the old directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I should change the name of it to
newreposecretwithlibsodium
?
Sure, that sounds like a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @andersjanmyr !
LGTM.
If you want to rename the older libsodium example dir in this PR, that's fine with me.
Also, if you want to clean up any of the comment in that older example, that would be awesome too... (I see that you cleaned up some of the wording here... and maybe some of those cleanups also apply to the older example, but if not, that's OK too... thanks!)
@@ -0,0 +1,11 @@ | |||
module newreposecret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module newreposecret | |
module newreposecretwithxcrypto |
Fixed the comments and modules. |
@@ -1,13 +1,13 @@ | |||
// Copyright 2020 The go-github AUTHORS. All rights reserved. | |||
// Copyright 2021 The go-github AUTHORS. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear before... any new file needs the current year it was created...
but any old file retains its original year which it was created (even if the file is renamed)...
so please revert this one line back to 2020
. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 fixed.
0aa4c1b
to
4d9b226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @andersjanmyr !
LGTM.
Merging.
The example that is using libsodium is hard to cross compile.
Here's an alternative example using
google.com/x/crypto
instead.Perhaps it should be added as an alternative file instead of change to the current one.