Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test from #1938 and #1904 #1956

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Fix test from #1938 and #1904 #1956

merged 1 commit into from
Jul 8, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jul 8, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1956 (5b84a87) into master (000ab79) will increase coverage by 25.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1956       +/-   ##
===========================================
+ Coverage   72.14%   97.84%   +25.69%     
===========================================
  Files          98      105        +7     
  Lines        6373     6809      +436     
===========================================
+ Hits         4598     6662     +2064     
+ Misses        912       80      -832     
+ Partials      863       67      -796     
Impacted Files Coverage Δ
github/actions_runners.go 100.00% <ø> (+42.37%) ⬆️
github/actions_workflow_runs.go 100.00% <ø> (+41.17%) ⬆️
github/activity.go 100.00% <ø> (ø)
github/apps.go 95.29% <ø> (+35.29%) ⬆️
github/apps_manifest.go 100.00% <ø> (+40.00%) ⬆️
github/code-scanning.go 100.00% <ø> (+33.33%) ⬆️
github/event_types.go 100.00% <ø> (ø)
github/issues_comments.go 100.00% <ø> (+19.60%) ⬆️
github/issues_timeline.go 100.00% <ø> (+33.33%) ⬆️
github/messages.go 97.05% <ø> (+0.28%) ⬆️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a9b44...5b84a87. Read the comment docs.

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit 0f0b9a5 into google:master Jul 8, 2021
@gmlewis gmlewis deleted the test-1938 branch July 8, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants