Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for CloudBilling resource #314

Merged

Conversation

shravankshenoy
Copy link
Contributor

Description

Issue #247 . Adds support for cloudbilling resource

Changes Made

  • Created new client factory in client package : cloud_billing_client.py
  • Created new crawler factory in the crawler package : cloud_billing_account_crawler.py
  • In the scanner.py file, included the crawler in the crawl loop and updated the crawl_client_map.
  • Modified example.config
  • Added unit tests in test_unit.py
  • Created bootstrap shell script to enable cloudbilling API (and code to link billing account to current project if required)
  • Added sample output for testing

Note

Unlike most other resources, a single project can only have 1 billing account associated with it. Programatically, this would mean an if condition is used instead of a while loop in the crawler as only one resource is returned for a given project.

@mshudrak mshudrak merged commit 11b53f3 into google:main Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants