Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links in Why Flax NNX documentation #4425

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Update links in Why Flax NNX documentation #4425

merged 1 commit into from
Dec 10, 2024

Conversation

rajasekharporeddy
Copy link
Contributor

@rajasekharporeddy rajasekharporeddy commented Dec 10, 2024 •
edited
Loading

What does this PR do?

Fixes some links in Why Flax NNX document.

Since we are talking about flax linen in the first paragraph of Why Flax NNX documentation, the links to collections and pseudorandom number generator (PRNG) management should re-direct to the glossary of linen instead of NNX.

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs.

cgarciae
cgarciae approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajasekharporeddy for doing this!

@copybara-service copybara-service bot merged commit 47122f2 into google:main Dec 10, 2024
11 of 17 checks passed
@rajasekharporeddy rajasekharporeddy deleted the testbranch1 branch December 11, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajasekharporeddy @cgarciae