Simplify GitHub actions #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are inconsistent with the rest of the jobs and they overflow the horizontal space in the GitHub UI.
The GitHub runners include rustup and a recent stable Rust. We only need to add the necessary target and we’re good to go. This removes a lot of warnings because the action used an outdated GitHub API: actions-rs/toolchain#219
The job is testing a single translation, so it should be singular.
mgeisler
force-pushed
the
simplify-actions
branch
3 times, most recently
from
ed236b0 to
9caafe9
Compare
This simplifies the workflow a little and ensures that we get artifacts uploaded of the English version for every PR.
GitHub actions supports setting the working directory directly.
Right now, the artifacts all contain the same two top-level folders: html/ and exerciser/. The former is what we actually deploy, the second is a side-effect of the exerciser plugin. With this change, we only upload the HTML and we ensure the zip file for the xx language has a top-level comprehensive-rust-xx/ folder. This makes it much nicer to use the generated artifacts.
djmitche
approved these changes
May 8, 2023
NoahDragon
pushed a commit
to wnghl/comprehensive-rust
that referenced
this pull request
Jul 19, 2023
* Remove unnecessary jobs names They are inconsistent with the rest of the jobs and they overflow the horizontal space in the GitHub UI. * Remove unnecessary toolchain action The GitHub runners include rustup and a recent stable Rust. We only need to add the necessary target and we’re good to go. This removes a lot of warnings because the action used an outdated GitHub API: actions-rs/toolchain#219 * Simplify job name The job is testing a single translation, so it should be singular. * Test English source with translations This simplifies the workflow a little and ensures that we get artifacts uploaded of the English version for every PR. * Avoid shell command chain GitHub actions supports setting the working directory directly. * Upload only the book artifact Right now, the artifacts all contain the same two top-level folders: html/ and exerciser/. The former is what we actually deploy, the second is a side-effect of the exerciser plugin. With this change, we only upload the HTML and we ensure the zip file for the xx language has a top-level comprehensive-rust-xx/ folder. This makes it much nicer to use the generated artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanups to the GitHub actions.