Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for rewrite_polyfills in the API is missing #3104

Closed
mattwomple opened this issue Oct 12, 2018 · 5 comments
Closed

Documentation for rewrite_polyfills in the API is missing #3104

mattwomple opened this issue Oct 12, 2018 · 5 comments
Assignees

Comments

@mattwomple
Copy link

I noticed the output from the command-line closure compiler included polyfills (recognizable by inclusion of $jscomp object at the beginning of the code), but the API service and the demo compiler do not include polyfills by default. I stumbled around the internet for a while before I finally found an answer on stack overflow that pointed me to the rewrite_polyfills parameter. It would be great if rewrite_polyfills could be documented at https://developers.google.com/closure/compiler/docs/api-ref and the default noted.

@ChadKillingsworth
Copy link
Collaborator

We keep all the flags documented here now: https://github.com/google/closure-compiler/wiki/Flags-and-Options

But it would be nice if the developers site could be updated to point there.

@concavelenz
Copy link
Contributor

We should also rename the option, as it doesn't rewrite polyfills it simply includes them.

@Daijobou
Copy link

Daijobou commented Sep 27, 2021

https://github.com/google/closure-compiler/wiki/Flags-and-Options#library-and-framework-specific
rewrite_polyfills has a poor explanation there of what it does. At least for me.

@lauraharker
Copy link
Contributor

https://github.com/google/closure-compiler/wiki/Polyfills has some more details on --rewrite_polyfills. Also agree that ""Rewrite ES6 library calls" is not a good description of that that flag does.

I'll send out a change making

usage = "Rewrite ES6 library calls to use polyfills provided by the compiler's runtime.")
point there (https://github.com/google/closure-compiler/wiki/Flags-and-Options is generated from CommandLineRunner.java)

@lauraharker lauraharker self-assigned this Sep 28, 2021
copybara-service bot pushed a commit that referenced this issue Oct 1, 2021
@lauraharker
Copy link
Contributor

https://developers.google.com/closure/compiler/docs/api-ref now includes rewrite_polyfills so marking as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants