Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with GCC14 #7650

Closed
snnn opened this issue Jan 7, 2025 · 1 comment
Closed

Build failure with GCC14 #7650

snnn opened this issue Jan 7, 2025 · 1 comment

Comments

@snnn
Copy link

snnn commented Jan 7, 2025

To reproduce the issue:

  1. Download AlmaLinux release 8.10
  2. Install GCC 14. ( I installed gcc-toolset-14-gcc-14.2.1-1.1.el8_10.aarch64 and gcc-toolset-14-gcc-c++-14.2.1-1.1.el8_10.aarch64 RPM packages)
  3. Checkout xnnpack code and build it
 git clone https://github.com/google/XNNPACK.git
 cd XNNPACK/
 mkdir b
 cd b
 cmake .. -DCMAKE_BUILD_TYPE=Debug -G Ninja
 ninja

You will see:

/tmp/XNNPACK/src/f16-raddstoreexpminusmax/gen/f16-raddstoreexpminusmax-neonfp16arith-rr2-p2-u32.c: In function ‘xnn_f16_raddstoreexpminusmax_ukernel__neonfp16arith_rr2_p2_u32’:
/tmp/XNNPACK/src/f16-raddstoreexpminusmax/gen/f16-raddstoreexpminusmax-neonfp16arith-rr2-p2-u32.c:189:17: error: passing argument 1 of ‘vst1_lane_u16’ from incompatible pointer type [-Wincompatible-pointer-types]
  189 |   vst1_lane_u16(sum, vreinterpret_u16_f16(vacc_lo), 0);
      |                 ^~~
      |                 |
      |                 xnn_float16 * {aka _Float16 *}
In file included from /tmp/XNNPACK/src/f16-raddstoreexpminusmax/gen/f16-raddstoreexpminusmax-neonfp16arith-rr2-p2-u32.c:12:
/opt/rh/gcc-toolset-14/root/usr/lib/gcc/aarch64-redhat-linux/14/include/arm_neon.h:22267:26: note: expected ‘uint16_t *’ {aka ‘short unsigned int *’} but argument is of type ‘xnn_float16 *’ {aka ‘_Float16 *’}
22267 | vst1_lane_u16 (uint16_t *__a, uint16x4_t __b, const int __lane)
      |                ~~~~~~~~~~^~~
copybara-service bot pushed a commit that referenced this issue Jan 7, 2025
PiperOrigin-RevId: 712750665
copybara-service bot pushed a commit that referenced this issue Jan 7, 2025
PiperOrigin-RevId: 712750665
copybara-service bot pushed a commit that referenced this issue Jan 7, 2025
PiperOrigin-RevId: 712750665
copybara-service bot pushed a commit that referenced this issue Jan 17, 2025
copybara-service bot pushed a commit that referenced this issue Jan 17, 2025
copybara-service bot pushed a commit that referenced this issue Jan 17, 2025
snnn added a commit to microsoft/onnxruntime that referenced this issue Jan 22, 2025
### Description
Add custom vcpkg ports for the following packages:
1. cpuinfo
2. onnx 
3. pthreadpool  
4. xnnpack

Because:

- The cpuinfo/pthreadpool/xnnpack packages in the official vcpkg repo
are too old.
   - XNNPack's version is updated from 2022-12-22 to 2025-01-17
   - CPUINFO's version is updated from 2022-07-19 to 2024-12-09
- Pthreadpool's version is updated from 2020-04-10 to 2024-12-17, and
the source code location is changed from
https://github.com/Maratyszcza/pthreadpool to
https://github.com/google/pthreadpool
- The onnx package in the official repo requires building python from
source, which then requires a lot of additional dependencies to be
installed. This PR removes them.
- Added a disable_gcc_warning.patch file for xnnpack for addressing the
issue reported in google/XNNPACK#7650. I will
remove this patch when the issue is fully addressed.
- Added " -DONNX_DISABLE_STATIC_REGISTRATION=ON" to ONNX's config
options.
-
ashrit-ms pushed a commit to microsoft/onnxruntime that referenced this issue Jan 23, 2025
### Description
Add custom vcpkg ports for the following packages:
1. cpuinfo
2. onnx 
3. pthreadpool  
4. xnnpack

Because:

- The cpuinfo/pthreadpool/xnnpack packages in the official vcpkg repo
are too old.
   - XNNPack's version is updated from 2022-12-22 to 2025-01-17
   - CPUINFO's version is updated from 2022-07-19 to 2024-12-09
- Pthreadpool's version is updated from 2020-04-10 to 2024-12-17, and
the source code location is changed from
https://github.com/Maratyszcza/pthreadpool to
https://github.com/google/pthreadpool
- The onnx package in the official repo requires building python from
source, which then requires a lot of additional dependencies to be
installed. This PR removes them.
- Added a disable_gcc_warning.patch file for xnnpack for addressing the
issue reported in google/XNNPACK#7650. I will
remove this patch when the issue is fully addressed.
- Added " -DONNX_DISABLE_STATIC_REGISTRATION=ON" to ONNX's config
options.
-
guschmue pushed a commit to microsoft/onnxruntime that referenced this issue Mar 6, 2025
### Description
Add custom vcpkg ports for the following packages:
1. cpuinfo
2. onnx 
3. pthreadpool  
4. xnnpack

Because:

- The cpuinfo/pthreadpool/xnnpack packages in the official vcpkg repo
are too old.
   - XNNPack's version is updated from 2022-12-22 to 2025-01-17
   - CPUINFO's version is updated from 2022-07-19 to 2024-12-09
- Pthreadpool's version is updated from 2020-04-10 to 2024-12-17, and
the source code location is changed from
https://github.com/Maratyszcza/pthreadpool to
https://github.com/google/pthreadpool
- The onnx package in the official repo requires building python from
source, which then requires a lot of additional dependencies to be
installed. This PR removes them.
- Added a disable_gcc_warning.patch file for xnnpack for addressing the
issue reported in google/XNNPACK#7650. I will
remove this patch when the issue is fully addressed.
- Added " -DONNX_DISABLE_STATIC_REGISTRATION=ON" to ONNX's config
options.
-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants