sys/windows: update docs about secure way to load system DLLs #74284
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the documentation of the
syscall.LazyDLL
states to usewindows.LazyDLL
for secure loading of system DLLs. However, the use of thewindows.LazyDLL
structure is only secure (not vulnerable to DLL preloading/injection attacks) if the user creates the object through thewindows.NewLazySystemDLL
function or if they usewindows.NewLazyDLL
with an absolute path.Given all this, I think it is better to point to
windows.NewLazySystemDLL
function instead of thewindows.LazyDLL
structure in thesyscall.LazyDLL
documentation.