-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/internal: clean up completely #72137
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 1191377) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/655515. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Jes Cok: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-06T18:04:40Z","revision":"6e4cf494a72d88b8826155cbc51e5e8119278efa"} Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Michael Pratt: Patch Set 1: Code-Review+2 Commit-Queue+1 (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Michael Pratt: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Jes Cok: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
We've been slowly moving packages from runtime/internal to internal/runtime. For now, runtime/internal only has test packages. It's a good change to clean up the references to runtime/internal in the toolchain. Change-Id: I35c2e86b73d86bd17b58cc74c0682bde1c970a90
1191377
to
fad32e2
Compare
This PR (HEAD: fad32e2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/655515. Important tips:
|
Message from Jes Cok: Patch Set 2: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-07T01:05:55Z","revision":"e2a7f22b7dbd368c0827166b678eb77e5fac44a5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/655515. |
We've been slowly moving packages from runtime/internal to
internal/runtime. For now, runtime/internal only has test packages.
It's a good chance to clean up the references to runtime/internal
in the toolchain.
For #65355.