api: review next.txt before release

[bradfitz]

A couple people should review api/next.txt before Go 1.3 to make sure there's no glaring
naming/case/API mistake we're stuck with for Go 1.x.

Please reply to this bug once you've reviewed api/next.txt's additions.

[bradfitz]

Comment 1:

Ignoring the typically-boring-and-ugly stuff, the additions are:
ba12:api bradfitz$ grep -v "pkg syscall " next.txt | grep -v "pkg debug"
pkg archive/tar, const TypeGNUSparse = 83
pkg archive/tar, const TypeGNUSparse ideal-char
pkg archive/tar, type Header struct, Xattrs map[string]string
pkg compress/gzip, method (*Reader) Reset(io.Reader) error
pkg crypto/tls, const CurveP256 = 23
pkg crypto/tls, const CurveP256 CurveID
pkg crypto/tls, const CurveP384 = 24
pkg crypto/tls, const CurveP384 CurveID
pkg crypto/tls, const CurveP521 = 25
pkg crypto/tls, const CurveP521 CurveID
pkg crypto/tls, func DialWithDialer(*net.Dialer, string, string, *Config) (*Conn, error)
pkg crypto/tls, func NewLRUClientSessionCache(int) ClientSessionCache
pkg crypto/tls, type ClientSessionCache interface { Get, Put }
pkg crypto/tls, type ClientSessionCache interface, Get(string) (*ClientSessionState,
bool)
pkg crypto/tls, type ClientSessionCache interface, Put(string, *ClientSessionState)
pkg crypto/tls, type ClientSessionState struct
pkg crypto/tls, type Config struct, ClientSessionCache ClientSessionCache
pkg crypto/tls, type Config struct, CurvePreferences []CurveID
pkg crypto/tls, type ConnectionState struct, Version uint16
pkg crypto/tls, type CurveID uint16
pkg crypto/x509, func CreateCertificateRequest(io.Reader, *CertificateRequest,
interface{}) ([]uint8, error)
pkg crypto/x509, func ParseCertificateRequest([]uint8) (*CertificateRequest, error)
pkg crypto/x509, type CertificateRequest struct
pkg crypto/x509, type CertificateRequest struct, Attributes
[]pkix.AttributeTypeAndValueSET
pkg crypto/x509, type CertificateRequest struct, DNSNames []string
pkg crypto/x509, type CertificateRequest struct, EmailAddresses []string
pkg crypto/x509, type CertificateRequest struct, Extensions []pkix.Extension
pkg crypto/x509, type CertificateRequest struct, ExtraExtensions []pkix.Extension
pkg crypto/x509, type CertificateRequest struct, IPAddresses []net.IP
pkg crypto/x509, type CertificateRequest struct, PublicKey interface{}
pkg crypto/x509, type CertificateRequest struct, PublicKeyAlgorithm PublicKeyAlgorithm
pkg crypto/x509, type CertificateRequest struct, Raw []uint8
pkg crypto/x509, type CertificateRequest struct, RawSubject []uint8
pkg crypto/x509, type CertificateRequest struct, RawSubjectPublicKeyInfo []uint8
pkg crypto/x509, type CertificateRequest struct, RawTBSCertificateRequest []uint8
pkg crypto/x509, type CertificateRequest struct, Signature []uint8
pkg crypto/x509, type CertificateRequest struct, SignatureAlgorithm SignatureAlgorithm
pkg crypto/x509, type CertificateRequest struct, Subject pkix.Name
pkg crypto/x509, type CertificateRequest struct, Version int
pkg crypto/x509/pkix, type AttributeTypeAndValueSET struct
pkg crypto/x509/pkix, type AttributeTypeAndValueSET struct, Type asn1.ObjectIdentifier
pkg crypto/x509/pkix, type AttributeTypeAndValueSET struct, Value
[][]AttributeTypeAndValue
pkg encoding/asn1, method (ObjectIdentifier) String() string
pkg go/build, type Package struct, MFiles []string
pkg math/big, method (*Int) MarshalText() ([]uint8, error)
pkg math/big, method (*Int) UnmarshalText([]uint8) error
pkg math/big, method (*Rat) MarshalText() ([]uint8, error)
pkg math/big, method (*Rat) UnmarshalText([]uint8) error
pkg net, type Dialer struct, KeepAlive time.Duration
pkg net/http, const StateActive = 1
pkg net/http, const StateActive ConnState
pkg net/http, const StateClosed = 4
pkg net/http, const StateClosed ConnState
pkg net/http, const StateHijacked = 3
pkg net/http, const StateHijacked ConnState
pkg net/http, const StateIdle = 2
pkg net/http, const StateIdle ConnState
pkg net/http, const StateNew = 0
pkg net/http, const StateNew ConnState
pkg net/http, method (*Server) SetKeepAlivesEnabled(bool)
pkg net/http, method (ConnState) String() string
pkg net/http, type Client struct, Timeout time.Duration
pkg net/http, type ConnState int
pkg net/http, type Response struct, TLS *tls.ConnectionState
pkg net/http, type Server struct, ConnState func(net.Conn, ConnState)
pkg net/http, type Server struct, ErrorLog *log.Logger
pkg net/http, type Transport struct, TLSHandshakeTimeout time.Duration
pkg regexp/syntax, method (*Inst) MatchRunePos(int32) int
pkg regexp/syntax, method (*Inst) OnePassNext(int32) uint32
pkg regexp/syntax, method (*Prog) CompileOnePass() *Prog
pkg regexp/syntax, method (*Prog) OnePassPrefix() (string, bool, uint32)
pkg regexp/syntax, method (InstOp) String() string
pkg regexp/syntax, type Inst struct, Next []uint32
pkg regexp/syntax, var NotOnePass *Prog
pkg runtime/debug, func SetPanicOnFault(bool) bool
pkg runtime/debug, func WriteHeapDump(uintptr)
pkg sync, method (*Pool) Get() interface{}
pkg sync, method (*Pool) Put(interface{})
pkg sync, type Pool struct
pkg sync, type Pool struct, New func() interface{}
pkg testing, method (*B) RunParallel(func(*PB))
pkg testing, method (*B) SetParallelism(int)
pkg testing, method (*PB) Next() bool
pkg testing, type PB struct
pkg unicode, const Version = "6.3.0"

[rsc]

Comment 2:

We should also make sure most of this is in go1.3.html.

[bradfitz]

Comment 4:

These two are oddly similar, but at least documented, but I'm wondering if their names
are ideal:
 
pkg crypto/x509, type CertificateRequest struct, Extensions []pkix.Extension
pkg crypto/x509, type CertificateRequest struct, ExtraExtensions []pkix.Extension

[rsc]

Comment 5:

I agree about crypto/x509 in theory, but since it's X.509 I'm willing to let it slide,
especially at this point, and especially if agl wants to leave it as is.
go1.3.html should mention that big.Int and big.Rat now implement encoding.TextMarshaler
and encoding.TextUnmarshaler.
I want to take a closer look at regexp/syntax.
I'm happy with everything else.

[bradfitz]

Comment 6:

I've never been happy about the name and stutter of:
pkg crypto/tls, func DialWithDialer(*net.Dialer, string, string, *Config) (*Conn, error)
I can live with it, but I think a tls.Dialer struct that embeds a *net.Dialer and
contains a *tls.Config would be nicer. Then the curried tls.Dialer.Dial method fits the
shape needed by e.g. the http.Transport.Dial func hook, and is consistent with the
net.Dialer struct + method.
But otherwise I'm happy with the rest.

[gopherbot]

Comment 7:

CL https://golang.org/cl/98610046 mentions this issue.

[rsc]

Comment 8:

Brad, re #6, if the change is tiny, send it now. Not sure you need to embed as opposed
to just having an ordinary struct field.

[rsc]

Comment 9:

This issue was updated by revision 6c10e64.

Hide one-pass regexp API.
This means moving the code from regexp/syntax to regexp,
but it avoids being locked into the specific API chosen for
the implementation.
It also removes a slice field from the syntax.Inst, which
should avoid bloating the memory footprint of a non-one-pass
regexp unnecessarily.
LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://golang.org/cl/98610046

[agl]

Comment 10:

Extensions and ExtraExtensions in CertificateRequest matches x509.Certificate.
Extensions is filled in when reading certificates and ExtraExtensions are added when
writing them out.
Happy to have the Dialer be an element of tls.Config and have people wrap a closure if
Brad likes that.

[bradfitz]

Comment 11:

Nevermind about DialWithDialer. It returns a *tls.Conn type, not a net.Conn interface,
so that removes most of my motivation for changing it.
I'm happy with it as it is.

[gopherbot]

Comment 12:

CL https://golang.org/cl/95640043 mentions this issue.

[rsc]

Comment 13:

This issue was updated by revision c038c38.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/95640043

[rsc]

Comment 14:

I'm happy with everything now. Rob, do you want to look at the list too? (See comment
#1.)

[robpike]

Comment 15:

LGTM

[rsc]

Comment 16:

Status changed to Fixed.