runtime: throw comment says it's marked go:noinline but it's not

[awmorgan]

commit 9eebdca added a comment saying

// NOTE: temporarily marked "go:noinline" pending investigation/fix of
// issue #67274, so as to fix longtest builders.

//go:noinline was removed in bf0b605 but the comment was left.

[Jorropo]

Thx, #67274 is closed do you want to send a CL removing this comment ?

[gopherbot]

Change https://go.dev/cl/643455 mentions this issue: runtime: delete out of date comment

[awmorgan]

@Jorropo This is my first change. I may have messed up somehow. I tried force pushing back to my fork but it did not show up in gerrit. gerrit says it's abandoned now.

here was the change:

commit 61d1d22e7c3895a8b13008876a7b788c9ffa2781 (HEAD -> master, origin/master, origin/HEAD)
Author: Bill Morgan <[email protected]>
Date:   Sun Jan 19 19:55:52 2025 -0600

    runtime: delete out of date comment

    Fixes #71328

i also added gerrit as a remote and tried pushing but that got rejected:

$ git push gerrit HEAD:refs/for/master
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 24 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 492 bytes | 70.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (4/4)
remote: Waiting for private key checker: 1/1 objects left
remote: Processing changes: refs: 1, done
remote: ERROR: commit 61d1d22: missing Change-Id in message footer
remote:
remote: Hint: to automatically insert a Change-Id, install the hook:
remote: go install golang.org/x/review/git-codereview@latest && git-codereview hooks
remote: and then amend the commit:
remote:   git commit --amend --no-edit
remote: Finally, push your changes again
remote:
To https://go-review.googlesource.com/go
 ! [remote rejected]       HEAD -> refs/for/master (commit 61d1d22: missing Change-Id in message footer)
error: failed to push some refs to 'https://go-review.googlesource.com/go'

I then tried following the hint in the remote reject message and that did not work either:

arthu@anakin MINGW64 ~/git/go_tmp/src (master)
$ go install golang.org/x/review/git-codereview@latest && git-codereview hooks

arthu@anakin MINGW64 ~/git/go_tmp/src (master)
$ git commit --amend --no-edit
[master 26f4eab182] runtime: delete out of date comment
 Date: Sun Jan 19 19:55:52 2025 -0600
 1 file changed, 3 deletions(-)

arthu@anakin MINGW64 ~/git/go_tmp/src (master)
$ git log -1
commit 26f4eab182130c709be269491049fade3327ddd3 (HEAD -> master)
Author: Bill Morgan <[email protected]>
Date:   Sun Jan 19 19:55:52 2025 -0600

    runtime: delete out of date comment

    Fixes #71328

arthu@anakin MINGW64 ~/git/go_tmp/src (master)
$ git push gerrit HEAD:refs/for/master
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 24 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 491 bytes | 61.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (4/4)
remote: Waiting for private key checker: 1/1 objects left
remote: Processing changes: refs: 1, done
remote: ERROR: commit 26f4eab: missing Change-Id in message footer
remote:
remote: Hint: to automatically insert a Change-Id, install the hook:
remote: go install golang.org/x/review/git-codereview@latest && git-codereview hooks
remote: and then amend the commit:
remote:   git commit --amend --no-edit
remote: Finally, push your changes again
remote:
To https://go-review.googlesource.com/go
 ! [remote rejected]       HEAD -> refs/for/master (commit 26f4eab: missing Change-Id in message footer)
error: failed to push some refs to 'https://go-review.googlesource.com/go'

arthu@anakin MINGW64 ~/git/go_tmp/src (master)
$

[Jorropo]

@awmorgan it shows up as abandoned because you closed the PR, it can take multiple minutes for the bot to update gerrit when you push to your own pull request. 🙂
Force push to the PR should work otherwise.
Maybe try reopening your PR. edit: nvm I did it (I don't know what it will do because the CL has been abandoned, if it doesn't work in an hour try reopening a new branch & PR for this time)

[gopherbot]

Change https://go.dev/cl/643456 mentions this issue: runtime: delete out of date comment