x/build: update OpenBSD builders to 7.6 #69823
Comments
|
Some useful details also in #63568 (comment) |
|
Change https://go.dev/cl/618895 mentions this issue: |
cherrymui
added
the
NeedsFix
OpenBSD 7.6 has been released, meaning that the only two supported versions are 7.5 and 7.6. Update the image build script for 7.6. Additionally, bump the maxproc limit for the swarming user, which will hopefully reduce the number of failures due to fork/exec returning EAGAIN. Updates golang/go#66474 Updates golang/go#69823 Change-Id: Ie2667de2defefbb6a56adca3dec92d7663c615e4 Reviewed-on: https://go-review.googlesource.com/c/build/+/618895 Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
|
@dmitshur any idea when/how we can get this rolled out? |
|
For the 386/amd64 builders that we run as VMs in GCE, this will first need to go through a process similar to what was recently done in #61095 (e.g., see CL 616836 which added the ability to bootstrap the swarming bot for LUCI), which is tracked in #61122. I'll increase the visibility of that issue within our list of available builder-related work, but I can't say how quickly someone will be able to get to it. For reverse builders owned by @golang/openbsd builder owners, it's a matter of updating the OS version where the swarming bot runs. |
I may be missing something, however the The
They're all already on OpenBSD 7.6, with the exception of |
|
Additionally, as I just noted on #61122, as far as I can see the openbsd/386 image should already be LUCI capable (since openbsd/amd64 and they share the same build script). |
|
Change https://go.dev/cl/653496 mentions this issue: |
For golang/go#69823. Change-Id: I9b9aed05dd12cdc0c1a409054f5ca0e041f4c4e1 Reviewed-on: https://go-review.googlesource.com/c/build/+/653496 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Pratt <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
|
The image and configuration for openbsd/amd64 with OpenBSD 7.6 are in place, but the swarming bot is currently failing to start up. I commented here with the details. |
|
@dmitshur - that's rather strange - the python package installs /usr/local/bin/python3 and /usr/local/bin is included in the PATH that is exported before the su invocation (none of this really changed with the make.bash update). If I build the image and boot it everything appears to be correct. Is there a chance that the image failed to build correctly and that the python package did not actually get installed? The build output should include: Are you able to boot the image and see if /usr/local/bin/python3 exists (or provide a way to access the image so I can check)? |
|
@4a6f656c Thanks for the hint, it was right on. The output from my run of I'll start the process a second time and see if the problem is reproducible or one-off. (It would also be good if such a failure were to produce an error and stop the process, if it's possible to adjust make.bash to be able to catch it.) |
|
Trying it again without any changes resulted in no errors this time: The resulting image this time successfully started a swarming bot instance, which connected okay and we have a first build at https://ci.chromium.org/b/8721307255879001089. Thanks for the help. I'll work on the next steps of turning it up for x/ repos. |
|
Change https://go.dev/cl/654675 mentions this issue: |
|
Change https://go.dev/cl/654676 mentions this issue: |
The image was built successfully (on second try) and has proven to work in the main Go repo (https://ci.chromium.org/b/8721307255879001089), so take the next step of enabling this builder for golang.org/x repos. For golang/go#69823. Change-Id: Ic5c8aee36f3d2f0f3ff57525f996a3da600c25a0 Reviewed-on: https://go-review.googlesource.com/c/build/+/654675 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Junyang Shao <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
|
From looking at https://ci.chromium.org/ui/p/golang/builders?q=openbsd-amd64_7.6, the openbsd/amd64 builder with OpenBSD 7.6 is still running into what looks like #66474, possibly less frequently after the :maxproc-{cur,max} doubling. It's working okay in almost all x/ repos, but x/tools needs some action. Filed #72145 for that. |
OpenBSD 7.6 has just been released (https://www.openbsd.org/76.html) - this means that the only two supported OpenBSD releases are now 7.5 and 7.6. The current openbsd-amd64 and openbsd-386 builders are running 7.2 which is unsupported. As such, these should be updated to run 7.6.
The text was updated successfully, but these errors were encountered: