Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/doc: IsPredeclared missing clear, min, max #68028

Closed
jfrech opened this issue Jun 17, 2024 · 3 comments
Closed

go/doc: IsPredeclared missing clear, min, max #68028

jfrech opened this issue Jun 17, 2024 · 3 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@jfrech
Copy link

jfrech commented Jun 17, 2024

Go version

1.22.4

Output of go env in your module/workspace:

go.dev/play "Go 1.22"

What did you do?

I browsed https://cs.opensource.google/go/go/+/refs/tags/go1.22.4:src/go/doc/reader.go;l=979 and got curious when not finding "max" in said set.

What did you see happen?

As https://go.dev/play/p/r88vggchOkT demonstrates, "clear", "max" and "min" aren't regarded as [go/doc.IsPredeclared].

What did you expect to see?

As per the specification (cf. https://go.dev/ref/spec#Predeclared_identifiers [2024-06-17]), "clear", "max" and "min" are categorized as predeclared which [go/doc.IsPredeclared] should reflect.

@mauri870
Copy link
Member

mauri870 commented Jun 17, 2024

Thanks, that seems to have been overlooked.

I wonder if this can be included in the 1.23 freeze? It should be cherry-picked to 1.21 and 1.22 as well.

cc @griesemer @golang/release

@mauri870 mauri870 added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 17, 2024
@dmitshur dmitshur added this to the Go1.23 milestone Jun 17, 2024
@seankhliao seankhliao changed the title go/doc: IsPredeclared is lagging behind the specification go/doc: IsPredeclared missing clear, min, max Jun 17, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/593015 mentions this issue: go/doc: Added the IsPredeclared clear, min, max

@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants