x/tools/gopls: support "go to implementation" (textDocument/implementation) for function types

[a-h]

As of gopls v0.10.1, the go to implementation feature of the LSP supports finding all of the types which implement an interface via the "Go to Implementation" feature in VS Code and Neovim etc.

This is a feature request to add the same support for named function types, and anonymous functions.

Current behaviour

go_to_implementation_interface.mov

Go also allows you to define function types and also accept functions as a parameter. This is seen in the standard library, e.g. https://pkg.go.dev/net/http#HandlerFunc and https://pkg.go.dev/strings#IndexFunc but here's a simple example.

type FunctionType func(s string, i int)

Any function that has the same signature implements that function type.

func ImplementationOfFunctionType1(s string, i int) {
}

func ImplementationOfFunctionType2(s string, i int) {
}

So, you can use it like this:

func TestFunctionType(f FunctionType) {
	f("s", 0)
}

The current behaviour of gopls does not allow you to go to the implementation of f from within the function body of the TestFunctionType function.

go_to_implementation_function_current.mov

And this same behaviour is true of anonymous functions:

go_to_implementation_function_anon_current.mov

Expected behavior

It should be possible to go the functions which implement the signature, as per this example.

go_to_function_type_implementation.mov

I've also tested the same behaviour with my modified version of the gopls Language Server running with Neovim.

Implementation

I've got an implementation of the functionality to contribute.

[findleyr]

Hi, if you already have an implementation for this, we can take a look. As long as it is not too invasive, this is a feature we'd happily accept. Thanks!

[a-h]

Thanks @findleyr - I've added a PR over here: golang/tools#412

I've tried to keep the new features out of the way as much as possible.

[gopherbot]

Change https://go.dev/cl/619195 mentions this issue: gopls/internal/golang: allow Implementation on any expression

[gopherbot]

Change https://go.dev/cl/654556 mentions this issue: gopls/internal/golang: Implementations for func types

[gopherbot]

Change https://go.dev/cl/655175 mentions this issue: gopls/internal/util/fingerprint: split from cache/methodsets