x/build/cmd/gerritbot: auto-wrap description

[myitcv]

Per https://go-review.googlesource.com/c/vgo/+/105335/9//COMMIT_MSG#9 it would be good/nice to have gerritbot auto-wrap the first comment to save people having to do this by hand (which in a webpage text box is painful)

cc @andybons

[ianlancetaylor]

I'm not entirely comfortable with breaking long lines in the CL description. Those lines might be source code or other text with meaningful line breaks. I don't care much what happens with text that people type into the edit box on the web page, but I don't see how to reliably do the right thing with description sent in via git mail.

[myitcv]

@ianlancetaylor - might be I've misclassified this for "gerritbot"; I was only looking to automate the wrapping of the description take from the Github PR when populating the CL description.

i.e. for golang/vgo#3 we would auto-wrap the description that is in the first comment:

Or did I misunderstand your point?

[ianlancetaylor]

Ah, no, I misunderstood. Sure, it's fine with me to wrap when moving from a GitHub pull request to Gerrit.

[thepudds]

Hi @heschi (or anyone), I'm curious if this is an example of something that Tricium could easily flag (e.g., maybe there is a rule already)?

Also, my guess is that flagging the issue might be a sufficient solution even if the text is not automatically corrected. That would presumably be simpler to implement, and probably helps with false positives. (That is, it might be a bit annoying if your nice ASCII table is flagged for line length in an automatically added comment, but it would be much more annoying if your nice ASCII table was automatically mangled by word-wrapping).

[heschi]

There are surprisingly few prebuilt Tricium analyzers, so no, there isn't something off the shelf. It should be pretty easy to add one. Or it might be possible to add directly to our recipe without much ceremony:
https://cs.opensource.google/go/x/build/+/luci-config:recipes/recipes/tricium_simple.py

But we haven't gotten much experience working with Tricium so even though it seems like an easy thing to add we probably won't get to it for a while.

Various doc links:
https://chromium.googlesource.com/infra/infra/+/main/go/src/infra/tricium/docs/contribute.md
https://crsrc.org/i/recipes-py/recipe_modules/tricium/api.py