Skip to content

slog-handler-guide: remove doubled word #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bitlux
Copy link
Contributor

@bitlux bitlux commented Apr 3, 2025

No description provided.

@gopherbot
Copy link

This PR (HEAD: bca7c8e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/example/+/662795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@bitlux bitlux changed the title example/slog-handler-guide: Remove doubled word example/slog-handler-guide: remove doubled word Apr 4, 2025
@gopherbot
Copy link

Message from Adam Bender:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jonathan Amsterdam:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Jonathan Amsterdam:

Patch Set 2: Auto-Submit+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Sean Liao:

Patch Set 2: Auto-Submit+1 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-06T16:39:32Z","revision":"5d969d9b85db13e5e3c4f92feb7ad4be599f69a7"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Sean Liao:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Sean Liao:

Patch Set 2: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/662795.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur changed the title example/slog-handler-guide: remove doubled word slog-handler-guide: remove doubled word Apr 7, 2025
gopherbot pushed a commit that referenced this pull request Apr 7, 2025
Change-Id: I2fc1ead51b4da07a56201ceab4abd4f9e0643294
GitHub-Last-Rev: bca7c8e
GitHub-Pull-Request: #38
Reviewed-on: https://go-review.googlesource.com/c/example/+/662795
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Sean Liao <[email protected]>
@bitlux bitlux closed this Apr 11, 2025
passionate-dev219 added a commit to passionate-dev219/gopher-golang-project that referenced this pull request May 7, 2025
Change-Id: I2fc1ead51b4da07a56201ceab4abd4f9e0643294
GitHub-Last-Rev: bca7c8e7ef1c904b29f6b133a9857bde7b646cc0
GitHub-Pull-Request: golang/example#38
Reviewed-on: https://go-review.googlesource.com/c/example/+/662795
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Jonathan Amsterdam <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Sean Liao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants