Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net/ghttp): nil pointer panic error when server logger set nil #4055

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Dec 17, 2024

fix #4047

@houseme
Copy link
Member

houseme commented Dec 17, 2024

是不是搞个默认兜底的呢?这样处理就必须要设置了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Is there a way to keep everything in check by default? In this way, it is necessary to set up

@gqcn
Copy link
Member Author

gqcn commented Dec 17, 2024

是不是搞个默认兜底的呢?这样处理就必须要设置了

是允许将Logger设置为nil的,表示不打印日志,但是会引起一些内部的问题,因为内部逻辑没处理好,这里就做了一些判断改进。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Is there a way to keep everything secret by default? In this way, it is necessary to set up

It is allowed to set Logger to nil, which means no logs will be printed, but it will cause some internal problems because the internal logic is not handled well, so some judgment improvements have been made here.

@gqcn gqcn merged commit 594979c into master Dec 19, 2024
34 checks passed
@gqcn gqcn deleted the fix/4047 branch December 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants