gerror: compatibility standard library error , IIs interface not implemented #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqcn
requested changes
Jun 11, 2024
| if !ok { | ||
| e = Wrap(err, "").(IIs) | ||
| } | ||
| return e.Is(target) |
There was a problem hiding this comment.
是否这样改动更合适一些：
e, ok := err.(IIs)
if ok {
return e.Is(target)
}
return err == targetThere was a problem hiding this comment.
如果改成这样，这个测试用例就过不了：t.Assert(gerror.Is(errors.New("1"), gerror.New("1")), true)
There was a problem hiding this comment.
如果改成这样，这个测试用例就过不了：t.Assert(gerror.Is(errors.New("1"), gerror.New("1")), true)
看了下，这个t.Assert(gerror.Is(errors.New("1"), gerror.New("1")), true)本来就不应该过。我新建了分支合并了你的提交新建了pr到这里 #3640 ，这个pr就可以关闭了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3633