Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #2244 #2257

Merged
merged 3 commits into from
Nov 3, 2022
Merged

fix issue #2244 #2257

merged 3 commits into from
Nov 3, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Nov 3, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 76.53% // Head: 76.56% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ad403b0) compared to base (ab79134).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head ad403b0 differs from pull request most recent head 9099db1. Consider uploading reports for the commit 9099db1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
+ Coverage   76.53%   76.56%   +0.02%     
==========================================
  Files         582      582              
  Lines       48394    48401       +7     
==========================================
+ Hits        37040    37056      +16     
+ Misses       9328     9318      -10     
- Partials     2026     2027       +1     
Flag Coverage Δ
go-1.15-386 76.57% <100.00%> (+0.04%) ⬆️
go-1.15-amd64 76.61% <100.00%> (+0.03%) ⬆️
go-1.16-386 76.58% <100.00%> (+0.02%) ⬆️
go-1.16-amd64 76.59% <100.00%> (+0.03%) ⬆️
go-1.17-386 76.61% <100.00%> (+0.03%) ⬆️
go-1.17-amd64 76.59% <100.00%> (+<0.01%) ⬆️
go-1.18-386 76.50% <100.00%> (+<0.01%) ⬆️
go-1.18-amd64 76.52% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gtime/gtime_time.go 82.06% <100.00%> (+0.49%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (+5.04%) ⬆️
os/gcron/gcron_schedule_fix.go 100.00% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit a1b9eca into master Nov 3, 2022
@gqcn gqcn deleted the fix/2244 branch November 3, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants