Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/driver-dm fix something is invalid in dm #2158

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

zhonghuaxunGM
Copy link
Member

  1. fix core.hasfield error index out of range
  2. fix GroupConcat is invalid in dm

@zhonghuaxunGM zhonghuaxunGM requested a review from gqcn September 27, 2022 10:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Base: 76.58% // Head: 76.55% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2f07f87) compared to base (66aa0c7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
- Coverage   76.58%   76.55%   -0.03%     
==========================================
  Files         577      579       +2     
  Lines       47899    47986      +87     
==========================================
+ Hits        36683    36737      +54     
- Misses       9222     9249      +27     
- Partials     1994     2000       +6     
Flag Coverage Δ
go-1.15-386 76.53% <100.00%> (+0.01%) ⬆️
go-1.15-amd64 76.48% <100.00%> (-0.02%) ⬇️
go-1.16-386 76.52% <100.00%> (?)
go-1.16-amd64 76.57% <100.00%> (+0.04%) ⬆️
go-1.17-386 76.52% <100.00%> (-0.01%) ⬇️
go-1.17-amd64 76.53% <100.00%> (+<0.01%) ⬆️
go-1.18-386 76.50% <100.00%> (?)
go-1.18-amd64 76.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/dm/dm.go 73.68% <100.00%> (+0.09%) ⬆️
contrib/config/kubecm/kubecm_kube.go 100.00% <0.00%> (ø)
contrib/config/kubecm/kubecm.go 41.53% <0.00%> (ø)
os/gcfg/gcfg.go 65.34% <0.00%> (+1.98%) ⬆️
os/gcron/gcron_schedule_fix.go 100.00% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit cd5bf7c into master Sep 28, 2022
@gqcn gqcn deleted the feature/driver-dm-fix branch September 28, 2022 02:02
houseme pushed a commit to houseme/gf that referenced this pull request Sep 30, 2022
* fix core.hasfield error index out of range & fix GroupConcat is invalid in dm

* add unit test

Co-authored-by: Xu <zhenghao.xu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants