Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gctx init slice bounds out of range on ios platform #2062

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

omegamt
Copy link
Contributor

@omegamt omegamt commented Aug 11, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #2062 (e5160d9) into master (e4c8cfc) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
- Coverage   76.47%   76.43%   -0.04%     
==========================================
  Files         517      516       -1     
  Lines       46828    46594     -234     
==========================================
- Hits        35810    35615     -195     
+ Misses       9041     9013      -28     
+ Partials     1977     1966      -11     
Flag Coverage Δ
go-1.15-386 ?
go-1.15-amd64 ?
go-1.16-386 76.38% <0.00%> (?)
go-1.16-amd64 76.38% <0.00%> (+0.03%) ⬆️
go-1.17-386 ?
go-1.17-amd64 ?
go-1.18-386 76.38% <0.00%> (?)
go-1.18-amd64 76.38% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gctx/gctx.go 84.84% <0.00%> (-5.78%) ⬇️
contrib/drivers/oracle/oracle.go
os/gspath/gspath_cache.go 94.73% <0.00%> (+7.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@houseme houseme requested a review from gqcn August 12, 2022 02:17
@gqcn gqcn added the wip label Aug 15, 2022
@gqcn
Copy link
Member

gqcn commented Aug 15, 2022

@omegamt IOS平台上的Env如果不带有=符号的话,是什么样子的?

@omegamt
Copy link
Contributor Author

omegamt commented Aug 15, 2022

@gqcn iPhone真机release是正常的 debug模式下 os.Environ() 模拟器上print 后, 其中有一行的值是 \371\246t\366\241!

@gqcn gqcn merged commit 897d6d9 into gogf:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants