Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve field type check from db to golang #2023

Merged
merged 10 commits into from
Jul 22, 2022
Merged

improve field type check from db to golang #2023

merged 10 commits into from
Jul 22, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jul 19, 2022

No description provided.

@gqcn gqcn requested review from houseme, hailaz and huangqian1985 July 19, 2022 10:09
@codecov-commenter
Copy link

Codecov Report

Merging #2023 (257f5da) into master (b7794a8) will increase coverage by 0.00%.
The diff coverage is 62.74%.

@@           Coverage Diff           @@
##           master    #2023   +/-   ##
=======================================
  Coverage   76.51%   76.51%           
=======================================
  Files         515      516    +1     
  Lines       46658    46712   +54     
=======================================
+ Hits        35700    35742   +42     
- Misses       8990     8999    +9     
- Partials     1968     1971    +3     
Flag Coverage Δ
go-1.15-386 76.41% <62.74%> (-0.02%) ⬇️
go-1.15-amd64 76.42% <62.74%> (+0.03%) ⬆️
go-1.16-386 76.44% <62.74%> (+0.02%) ⬆️
go-1.16-amd64 76.43% <62.74%> (+<0.01%) ⬆️
go-1.17-386 76.46% <62.74%> (-0.01%) ⬇️
go-1.17-amd64 76.48% <62.74%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_core_structure.go 71.71% <50.00%> (+2.74%) ⬆️
database/gdb/gdb_func_structure.go 65.78% <65.78%> (ø)
database/gdb/gdb_core_utility.go 57.62% <100.00%> (ø)
database/gdb/gdb_func.go 86.33% <100.00%> (ø)
os/gcron/gcron_schedule_fix.go 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7794a8...257f5da. Read the comment docs.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit 863bea1 into master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants