Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve package gerror, add HasCode/HasError function for package gerror #2006

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jul 14, 2022

No description provided.

@gqcn gqcn requested review from houseme, huangqian1985 and hailaz July 14, 2022 08:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #2006 (0598357) into master (98b2e8a) will increase coverage by 0.01%.
The diff coverage is 84.03%.

@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
+ Coverage   76.48%   76.49%   +0.01%     
==========================================
  Files         514      515       +1     
  Lines       46650    46666      +16     
==========================================
+ Hits        35679    35697      +18     
+ Misses       9000     8999       -1     
+ Partials     1971     1970       -1     
Flag Coverage Δ
go-1.15-386 ?
go-1.15-amd64 76.39% <84.03%> (+0.01%) ⬆️
go-1.16-386 76.42% <84.03%> (+<0.01%) ⬆️
go-1.16-amd64 ?
go-1.17-386 76.47% <84.03%> (+0.04%) ⬆️
go-1.17-amd64 76.43% <84.03%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/sqlite/sqlite.go 77.77% <ø> (ø)
errors/gerror/gerror_api_option.go 70.00% <ø> (ø)
errors/gerror/gerror_api_stack.go 75.38% <75.38%> (ø)
errors/gerror/gerror_error.go 70.73% <80.00%> (+2.05%) ⬆️
errors/gerror/gerror_api_code.go 82.55% <82.55%> (ø)
errors/gerror/gerror_api.go 90.62% <90.62%> (ø)
contrib/drivers/clickhouse/clickhouse.go 70.23% <100.00%> (+0.60%) ⬆️
contrib/drivers/pgsql/pgsql.go 66.05% <100.00%> (+0.15%) ⬆️
errors/gerror/gerror_error_code.go 53.84% <100.00%> (ø)
util/gvalid/gvalid_validator_check_map.go 88.88% <100.00%> (+0.08%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b2e8a...0598357. Read the comment docs.

@gqcn gqcn merged commit 5d51e9f into master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants