Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve package glog; fix issue in package gtrace #1952

Merged
merged 14 commits into from
Jun 28, 2022
Merged

improve package glog; fix issue in package gtrace #1952

merged 14 commits into from
Jun 28, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jun 28, 2022

  1. add interface ILogger for package glog
  2. fix issue in nil context returned for gtrace.WithTraceID if given traceID is invalid

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #1952 (4fc230a) into master (d7faae0) will increase coverage by 0.02%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master    #1952      +/-   ##
==========================================
+ Coverage   75.56%   75.58%   +0.02%     
==========================================
  Files         512      512              
  Lines       46398    46403       +5     
==========================================
+ Hits        35060    35075      +15     
+ Misses       9334     9325       -9     
+ Partials     2004     2003       -1     
Flag Coverage Δ
go-1.15-386 75.46% <62.96%> (-0.04%) ⬇️
go-1.15-amd64 75.48% <62.96%> (+0.01%) ⬆️
go-1.16-386 75.48% <62.96%> (+0.03%) ⬆️
go-1.16-amd64 75.49% <62.96%> (+0.01%) ⬆️
go-1.17-386 75.55% <62.96%> (+0.04%) ⬆️
go-1.17-amd64 75.54% <62.96%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gcron/gcron.go 0.00% <0.00%> (ø)
os/glog/glog.go 42.85% <ø> (ø)
os/glog/glog_logger_handler.go 91.17% <0.00%> (ø)
os/gtimer/gtimer_entry.go 80.88% <ø> (ø)
os/gcron/gcron_cron.go 53.27% <50.00%> (ø)
net/ghttp/ghttp_server.go 64.38% <66.66%> (ø)
os/gcron/gcron_entry.go 60.63% <71.42%> (+0.85%) ⬆️
net/gtrace/gtrace.go 70.51% <100.00%> (+5.17%) ⬆️
os/gfsnotify/gfsnotify_filefunc.go 74.02% <0.00%> (-3.90%) ⬇️
os/gcron/gcron_schedule.go 67.52% <0.00%> (+0.42%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57d71b...4fc230a. Read the comment docs.

@gqcn gqcn merged commit 2c169e2 into master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants