Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple gdb-group overrides #1890

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix multiple gdb-group overrides #1890

merged 1 commit into from
Jun 23, 2022

Conversation

qq375251855
Copy link
Contributor

Fix multiple gdb-group overrides

@gqcn gqcn added the wip label Jun 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1890 (60c0045) into master (ef04c8a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
- Coverage   73.72%   73.72%   -0.01%     
==========================================
  Files         509      509              
  Lines       46040    46040              
==========================================
- Hits        33942    33941       -1     
  Misses      10052    10052              
- Partials     2046     2047       +1     
Flag Coverage Δ
go-1.15-386 73.60% <100.00%> (-0.01%) ⬇️
go-1.15-amd64 73.62% <100.00%> (+0.01%) ⬆️
go-1.16-386 73.60% <100.00%> (-0.02%) ⬇️
go-1.16-amd64 73.63% <100.00%> (+<0.01%) ⬆️
go-1.17-386 73.67% <100.00%> (-0.02%) ⬇️
go-1.17-amd64 73.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/gdb/gdb_model_order_group.go 53.84% <100.00%> (ø)
contrib/registry/polaris/polaris_watcher.go 62.50% <0.00%> (-10.72%) ⬇️
os/gcache/gcache_adapter_memory_lru.go 89.58% <0.00%> (-8.34%) ⬇️
os/glog/glog_logger_rotate.go 65.85% <0.00%> (-1.47%) ⬇️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (+5.04%) ⬆️
net/gtcp/gtcp_pool.go 75.00% <0.00%> (+6.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef04c8a...60c0045. Read the comment docs.

@gqcn gqcn merged commit 19779cd into gogf:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants