Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gf pack arg -p / not affect #3611

Closed
ananclub opened this issue May 27, 2024 · 2 comments · Fixed by #3621
Closed

gf pack arg -p / not affect #3611

ananclub opened this issue May 27, 2024 · 2 comments · Fixed by #3621
Labels
bug It is confirmed a bug, but don't worry, we'll handle it. done This issue is done, which may be release in next version. question

Comments

@ananclub
Copy link

What do you want to ask?

As title, when run gf pack testpath packed/data.go -n packed -p / , use gf.Dump() list then packed res filename not start with / path, still start with testpath
@hailaz
Copy link
Member

hailaz commented May 30, 2024

的确有bug

gf/os/gres/gres_func_zip.go

Line 65 in 1793bf0

headerPrefix := strings.TrimRight(usedOption.Prefix, `\/`)

@hailaz hailaz added the bug It is confirmed a bug, but don't worry, we'll handle it. label May 30, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

There is indeed a bug

gf/os/gres/gres_func_zip.go

Line 65 in 1793bf0

headerPrefix := strings.TrimRight(usedOption.Prefix, `\/`)

hailaz added a commit that referenced this issue May 31, 2024
@hailaz
fix: #3611 gres pack prefix
8cf4515
@hailaz hailaz mentioned this issue May 31, 2024
Merged
@gqcn gqcn closed this as completed in #3621 Jun 4, 2024
gqcn pushed a commit that referenced this issue Jun 4, 2024
@hailaz
os/gres: fix #3611 add custom prefix / support for resource packing (…
4d916ae 
…#3621)
@gqcn gqcn added the done This issue is done, which may be release in next version. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It is confirmed a bug, but don't worry, we'll handle it. done This issue is done, which may be release in next version. question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(os/gres): add custom prefix / support for resource packing gogf/gf
4 participants
@ananclub @gqcn @hailaz @Issues-translate-bot