Make initialization settings take effect in SubViewport
#64138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SubViewport` has some initialization settings of its own, but these settings are not synchronized to the `RenderingServer` when initialized, which causes some problems. Split from godotengine#62854. This is a prerequisite to resolve godotengine#55471, still need to modify `update_mode` manually, or add as a child to `SubViewportContainer` (`update_mode` is automatically set to `UPDATE_ALWAYS`). Currently, `UPDATE_WHEN_VISIBLE` has no meaning for `SubViewport`. Presumably for **visible**, `RenderingServer` has different rules, viewport needs to have a visible **rect** to be considered **visible**, while `SubViewport` has only `size` and **no** `position`, so it is not considered **visible** even if it is set to be an active viewport (`RS::viewport_set_active`).
Rindbee
added a commit
to Rindbee/godot
that referenced
this pull request
Aug 10, 2022
Follow-up to godotengine#64138, split from godotengine#62854. `SubViewport` has some settings applied on initialization, and the side effects of these settings are delayed until it enters the tree.
|
Superseded by #68358. |
Rindbee
deleted the
make-initialization-settings-take-effect-in-SubViewport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubViewporthas some initialization settings of its own, but these settings are not synchronized to theRenderingServerwhen initialized, which causes some problems.Split from #62854.
This is a prerequisite to resolve #55471, still need to modify
update_modemanually, or add as a child toSubViewportContainer(update_modeis automatically set toUPDATE_ALWAYS).Currently,
UPDATE_WHEN_VISIBLEhas no meaning forSubViewport. Presumably for visible,RenderingServerhas different rules, viewport needs to have a visible rect to be considered visible, whileSubViewporthas onlysizeand noposition, so it is not considered visible even if it is set to be an active viewport (RS::viewport_set_active).