Allow creating meshes without vertex positions #62046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
force-pushed
the
vertexless-draw
branch
2 times, most recently
from
d34d12d to
e0cf325
Compare
clayjohn
changed the title
|
This looks good, but I fear users maaay make a mistake using the API and get no error because now this is valid? I was wondering if a format flag should be supplied (like |
clayjohn
force-pushed
the
vertexless-draw
branch
3 times, most recently
from
2ac813b to
06a47ea
Compare
|
@reduz Should be good to go now. It prints an error if drawing to create a mesh without a vertex buffer and without the |
reduz
approved these changes
Aug 19, 2022
|
needs rebase |
clayjohn
force-pushed
the
vertexless-draw
branch
from
06a47ea to
d98952a
Compare
mhilbrunner
reviewed
Aug 19, 2022
mhilbrunner
reviewed
Aug 19, 2022
mhilbrunner
approved these changes
Aug 19, 2022
…hes can now be constructed from an index buffer alone
clayjohn
force-pushed
the
vertexless-draw
branch
from
d98952a to
bbbcdd7
Compare
|
Thank you! |
Adrian-Samoticha
added a commit
to Adrian-Samoticha/godot
that referenced
this pull request
Jun 24, 2024
While the `RenderingServer::mesh_create_surface_data_from_arrays` method does support vertexless meshes (see godotengine#62046 and godotengine#83446), it enforces that the size of custom arrays is dependent on the size of the vertex array. This effectively means that custom arrays cannot be used in vertexless meshes. This commit changes the way the array length is computed so that if no vertex array is provided, its length will be inferred from the custom arrays, if provided. It therefore adds support for custom arrays in vertexless meshes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the second half of: #19473
This allows meshes to be created without using vertex positions (for example, a mesh can be created with just an index array. In certain cases it can be much more efficient to only pass an index array and then pull your vertex information from a storage buffer or texture.