Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport would be cleared even when clear_mode was set to never clear #60705

Merged
merged 1 commit into from
May 2, 2022
Merged

Viewport would be cleared even when clear_mode was set to never clear #60705

merged 1 commit into from
May 2, 2022

Conversation

awsker
Copy link
Contributor

@awsker awsker commented May 2, 2022 •
edited
Loading

Now clears only when required to. Also moved bgcolor declaration closer to its place of usage

@awsker awsker requested a review from a team as a code owner May 2, 2022 09:10
@awsker awsker changed the title Viewport would be cleared even when clear_mode was set to VIEWPORT_CL… Viewport would be cleared even when clear_mode was set to never clear May 2, 2022
@Calinou Calinou added this to the 4.0 milestone May 2, 2022
@Calinou
Copy link
Member

Calinou commented May 2, 2022

@awsker Does this close #55471?

@Calinou Calinou mentioned this pull request May 2, 2022
Closed
@awsker
Copy link
Contributor Author

awsker commented May 2, 2022

@awsker Does this close #55471?

It does not, to my knowledge

@akien-mga akien-mga merged commit 7f18149 into godotengine:master May 2, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@awsker @Calinou @akien-mga @clayjohn