Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix webrtc example that relied on JSON integers #1171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

goatchurchprime
Copy link

This fixes the problem identified by godotengine/godot#103374

The JSON.parse_string() creates floats instead of integers from numbers, which the example flagged as an error. The solution is to send integers as strings instead.

@aaronfranke
Copy link
Member

Isn't this a workaround, not a solution? JSON numbers are, in fact, floats. Any check like str(msg.type).is_valid_int() in the ws_webrtc.client._parse_msg() function is just not a good check, right?

@Calinou Calinou added the bug label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants