feature: supporting sqlite :memory: and mode=memory on the sqlite dri…

…ver (#717)

.gitignore

@@ -33,6 +33,7 @@ testdata/migrations/schema.sql
 vendor/
 .env
 .release-env
+.vscode
 
 # test data
 cockroach-data/

dialect_sqlite.go

@@ -182,22 +182,32 @@ func (m *sqlite) locker(l *sync.Mutex, fn func() error) error {
 }
 
 func (m *sqlite) CreateDB() error {
-	_, err := os.Stat(m.ConnectionDetails.Database)
+	durl := m.ConnectionDetails.Database
+
+	// Checking whether the url specifies in-memory mode
+	// as specified in https://github.com/mattn/go-sqlite3#faq
+	if strings.Contains(durl, ":memory:") || strings.Contains(durl, "mode=memory") {
+		log(logging.Info, "in memory db selected, no database file created.")
+
+		return nil
+	}
+
+	_, err := os.Stat(durl)
 	if err == nil {
-		return fmt.Errorf("could not create SQLite database '%s'; database exists", m.ConnectionDetails.Database)
+		return fmt.Errorf("could not create SQLite database '%s'; database exists", durl)
 	}
-	dir := filepath.Dir(m.ConnectionDetails.Database)
+	dir := filepath.Dir(durl)
 	err = os.MkdirAll(dir, 0766)
 	if err != nil {
-		return fmt.Errorf("could not create SQLite database '%s': %w", m.ConnectionDetails.Database, err)
+		return fmt.Errorf("could not create SQLite database '%s': %w", durl, err)
 	}
-	f, err := os.Create(m.ConnectionDetails.Database)
+	f, err := os.Create(durl)
 	if err != nil {
-		return fmt.Errorf("could not create SQLite database '%s': %w", m.ConnectionDetails.Database, err)
+		return fmt.Errorf("could not create SQLite database '%s': %w", durl, err)
 	}
 	_ = f.Close()
 
-	log(logging.Info, "created database '%s'", m.ConnectionDetails.Database)
+	log(logging.Info, "created database '%s'", durl)
 	return nil
 }
 

dialect_sqlite_test.go

@@ -1,3 +1,4 @@
+//go:build sqlite
 // +build sqlite
 
 package pop
@@ -144,18 +145,51 @@ func Test_ConnectionDetails_FinalizeOSPath(t *testing.T) {
 
 func TestSqlite_CreateDB(t *testing.T) {
 	r := require.New(t)
-	dir := t.TempDir()
-	p := filepath.Join(dir, "testdb.sqlite")
-	cd := &ConnectionDetails{
-		Dialect:  "sqlite",
-		Database: p,
-	}
+
+	cd := &ConnectionDetails{Dialect: "sqlite"}
 	dialect, err := newSQLite(cd)
 	r.NoError(err)
-	r.NoError(dialect.CreateDB())
 
-	// Creating DB twice should produce an error
-	r.EqualError(dialect.CreateDB(), fmt.Sprintf("could not create SQLite database '%s'; database exists", p))
+	t.Run("CreateFile", func(t *testing.T) {
+		dir := t.TempDir()
+		cd.Database = filepath.Join(dir, "testdb.sqlite")
+
+		r.NoError(dialect.CreateDB())
+		r.FileExists(cd.Database)
+	})
+
+	t.Run("MemoryDB_tag", func(t *testing.T) {
+		dir := t.TempDir()
+		cd.Database = filepath.Join(dir, "file::memory:?cache=shared")
+
+		r.NoError(dialect.CreateDB())
+		r.NoFileExists(cd.Database)
+	})
+
+	t.Run("MemoryDB_only", func(t *testing.T) {
+		dir := t.TempDir()
+		cd.Database = filepath.Join(dir, ":memory:")
+
+		r.NoError(dialect.CreateDB())
+		r.NoFileExists(cd.Database)
+	})
+
+	t.Run("MemoryDB_param", func(t *testing.T) {
+		dir := t.TempDir()
+		cd.Database = filepath.Join(dir, "file:foobar?mode=memory&cache=shared")
+
+		r.NoError(dialect.CreateDB())
+		r.NoFileExists(cd.Database)
+	})
+
+	t.Run("CreateFile_ExistingDB", func(t *testing.T) {
+		dir := t.TempDir()
+		cd.Database = filepath.Join(dir, "testdb.sqlite")
+
+		r.NoError(dialect.CreateDB())
+		r.EqualError(dialect.CreateDB(), fmt.Sprintf("could not create SQLite database '%s'; database exists", cd.Database))
+	})
+
 }
 
 func TestSqlite_NewDriver(t *testing.T) {