Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test timeout dynamic (#21) #45

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

k3rn31
Copy link
Member

@k3rn31 k3rn31 commented Jul 22, 2022

Now test timeout is based on the time it takes to gather the coverage, multiplied by 2. I added a coefficient of 2 not to be too strict with the timeouts and generate false positives. I don't know if it makes sense to have it configurable, considering that it should be an int.

@k3rn31 k3rn31 linked an issue Jul 22, 2022 that may be closed by this pull request
@k3rn31 k3rn31 requested a review from giose86 July 22, 2022 15:19
@k3rn31 k3rn31 self-assigned this Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #45 (bf619f7) into main (1cccabe) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head bf619f7 differs from pull request most recent head 7251898. Consider uploading reports for the commit 7251898 to get more accurate results

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   86.54%   86.49%   -0.06%     
==========================================
  Files          10       10              
  Lines         513      511       -2     
==========================================
- Hits          444      442       -2     
  Misses         54       54              
  Partials       15       15              
Flag Coverage Δ
unittests 86.49% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
coverage/coverage.go 100.00% <100.00%> (ø)
mutator/mutator.go 87.90% <100.00%> (-0.10%) ⬇️
log/log.go 92.10% <0.00%> (-0.76%) ⬇️
cmd/gremlins/main.go 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cccabe...7251898. Read the comment docs.

@k3rn31 k3rn31 force-pushed the 21-make-test-timeout-smart branch from ab8a4dc to 957485d Compare July 22, 2022 15:25
@k3rn31 k3rn31 added c/enhancement Category: An issue or PR related to sn enhancement p/medium Priority: Medium labels Jul 23, 2022
@k3rn31 k3rn31 added this to the v0.1.0 milestone Jul 23, 2022
@pull-request-size pull-request-size bot added the s/L Size: Denotes a Pull Request that changes 100-499 lines label Jul 23, 2022
@k3rn31 k3rn31 force-pushed the 21-make-test-timeout-smart branch 4 times, most recently from 32435bb to f9aa795 Compare July 23, 2022 08:24
giose86
giose86 previously approved these changes Jul 23, 2022
Signed-off-by: Davide Petilli <[email protected]>
@k3rn31 k3rn31 force-pushed the 21-make-test-timeout-smart branch from b732aae to 7251898 Compare July 23, 2022 10:12
@giose86 giose86 merged commit fb1b51c into main Jul 23, 2022
@giose86 giose86 deleted the 21-make-test-timeout-smart branch July 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/enhancement Category: An issue or PR related to sn enhancement p/medium Priority: Medium s/L Size: Denotes a Pull Request that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test timeout "smart"
2 participants