Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: update unit test name #204

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

fahimbagar
Copy link
Contributor

@fahimbagar fahimbagar commented Feb 10, 2023

Update wrong name in coverage_test.go.

Close #166

Proposed changes

Update the wrong name in coverage_tests.go

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes (make all)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Update wrong name in coverage_test.go.

Close go-gremlins#166
@pull-request-size pull-request-size bot added the s/XS Size: Denotes a PR that changes 0-9 lines label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #204 (b6a30d9) into main (2f1eaaa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          18       18           
  Lines        1322     1322           
=======================================
  Hits         1168     1168           
  Misses        128      128           
  Partials       26       26           
Flag Coverage Δ
unittests 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@k3rn31
Copy link
Member

k3rn31 commented Feb 10, 2023

Hello, thanks for the PR, I'm merging int.

@k3rn31 k3rn31 merged commit b62af32 into go-gremlins:main Feb 10, 2023
@fahimbagar fahimbagar deleted the update-unit-test-name branch February 10, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s/XS Size: Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong name of test case in coverage_test.go
2 participants