Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reports: add type statistics to report file #185

Merged
merged 3 commits into from
Oct 12, 2022
Merged

reports: add type statistics to report file #185

merged 3 commits into from
Oct 12, 2022

Conversation

rzeAkbari
Copy link
Collaborator

Proposed changes

Mutant type statistics are added in the root of the file. zero values are omitted

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes (make all)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@pull-request-size pull-request-size bot added the s/L Size: Denotes a Pull Request that changes 100-499 lines label Oct 9, 2022
@rzeAkbari rzeAkbari requested a review from k3rn31 October 9, 2022 18:46
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #185 (d06585d) into main (a02a1b0) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   88.27%   88.53%   +0.25%     
==========================================
  Files          18       18              
  Lines        1288     1317      +29     
==========================================
+ Hits         1137     1166      +29     
  Misses        126      126              
  Partials       25       25              
Flag Coverage Δ
unittests 88.53% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/report/report.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@k3rn31 k3rn31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is better if we put the mutator statistics in a sub object of the report.

@k3rn31 k3rn31 added this to the v0.5.0 milestone Oct 11, 2022
@k3rn31 k3rn31 added the c/feature Category: An issue or PR related to a new feature label Oct 11, 2022
@k3rn31 k3rn31 self-assigned this Oct 11, 2022
@codeclimate
Copy link

codeclimate bot commented Oct 12, 2022

Code Climate has analyzed commit d06585d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (70% is the threshold).

This pull request will bring the total coverage in the repository to 90.5% (0.2% change).

View more on Code Climate.

@k3rn31 k3rn31 merged commit 88fb17e into main Oct 12, 2022
@k3rn31 k3rn31 deleted the G-134 branch October 12, 2022 10:18
@k3rn31
Copy link
Member

k3rn31 commented Oct 26, 2022

Closed #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/feature Category: An issue or PR related to a new feature s/L Size: Denotes a Pull Request that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants