Add API endpoint for repo transfer #9947

6543 · 2020-01-23T02:31:50Z

docu (swagger)
function
test

GitHub Spec: link
original PR: https://gitea.artixlinux.org/artix/gitea/pulls/1

codecov-io · 2020-01-23T06:37:20Z

Codecov Report

Merging #9947 into master will increase coverage by 1.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #9947      +/-   ##
==========================================
+ Coverage   42.38%   43.44%   +1.05%     
==========================================
  Files         620      566      -54     
  Lines       80961    78978    -1983     
==========================================
- Hits        34317    34313       -4     
+ Misses      42408    40429    -1979     
  Partials     4236     4236

Impacted Files	Coverage Δ
models/migrations/v76.go	`0% <0%> (ø)`	⬆️
models/migrations/v70.go	`0% <0%> (ø)`	⬆️
models/migrations/migrations.go	`4.16% <0%> (+2.86%)`	⬆️
services/pull/temp_repo.go	`31.62% <0%> (-2.57%)`	⬇️
services/pull/patch.go	`67.92% <0%> (-1.89%)`	⬇️
modules/log/event.go	`64.61% <0%> (-1.03%)`	⬇️
models/gpg_key.go	`54.81% <0%> (-0.56%)`	⬇️
models/repo.go	`51.53% <0%> (+0.06%)`	⬆️
routers/repo/view.go	`39.47% <0%> (+0.87%)`	⬆️
services/pull/check.go	`56.64% <0%> (+1.39%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa9dfd...b64626b. Read the comment docs.

6543 · 2020-01-25T18:39:17Z

@camlafit here it is :)

routers/api/v1/repo/repo.go

6543 · 2020-01-26T03:18:18Z

@lunny done

integrations/api_repo_test.go

6543 · 2020-01-26T11:05:05Z

@lunny removed the nonesense :D

integrations/api_repo_test.go

6543 · 2020-01-26T20:48:26Z

@zeripath thanks :D

routers/api/v1/repo/repo.go

zeripath

small nit - stop routers/api/v1/repo/repo.go from getting too large by splitting out the transfer function as repo_transfer.go

6543 · 2020-01-26T22:45:02Z

@lunny look at last two commits - did code-refactor

lunny · 2020-01-27T05:03:53Z

I would like to rename repo/repo_migrate.go to repo/migrate.go.

6543 · 2020-01-27T05:19:35Z

@lunny removed prefix because of package/folder name ...

camlafit · 2020-01-27T08:55:00Z

Could be set teams_ids it's a great idea thanks :)

lunny · 2020-01-28T09:58:20Z

services/repository/transfer.go

+	if err != nil {
+		return err
+	}
+	for _, team := range teams {


Could you check the two things?

if the new owner is an orgnization?

if the teams are belong to the new owner?

6543 · 2020-01-29T00:13:16Z

AddRepository handle OrgCheck and DubleAdd Prefention for us!

gitea/models/org_team.go

Lines 274 to 280 in 1f01f53

    
           // AddRepository adds new repository to team of organization. 
        
           func (t *Team) AddRepository(repo *Repository) (err error) { 
        
           	if repo.OwnerID != t.OrgID { 
        
           		return errors.New("Repository does not belong to organization") 
        
           	} else if t.HasRepository(repo.ID) { 
        
           		return nil 
        
           	}

it also check if the teams are belong to the new owner?

6543 · 2020-01-29T00:15:43Z

And I already added a test witch make sure it works:

https://github.com/go-gitea/gitea/pull/9947/files#diff-ffd1c307569a21f7d0f7234d5e8f3724R407

6543 · 2020-01-29T00:16:47Z

@lunny I think there is no problem, your described

6543 · 2020-01-30T08:51:35Z

ed18d4688cb78317b315a8a3570603de8e289011 should make sure this functin os "atomic"

routers/api/v1/repo/transfer.go

6543 · 2020-01-31T10:21:23Z

ready to merge 🚀

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 23, 2020

6543 force-pushed the api-repo-transfer branch 3 times, most recently from 2c56968 to e861f30 Compare January 25, 2020 18:33

6543 changed the title ~~[WIP] API endpint for repo transfer~~ API endpint for repo transfer Jan 25, 2020

lunny added modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 26, 2020

lunny requested changes Jan 26, 2020

View reviewed changes

routers/api/v1/repo/repo.go Outdated Show resolved Hide resolved

6543 requested a review from lunny January 26, 2020 04:37

lunny added this to the 1.12.0 milestone Jan 26, 2020

lunny reviewed Jan 26, 2020

View reviewed changes

integrations/api_repo_test.go Outdated Show resolved Hide resolved

6543 requested a review from lunny January 26, 2020 15:43

6543 commented Jan 26, 2020

View reviewed changes

integrations/api_repo_test.go Outdated Show resolved Hide resolved

6543 force-pushed the api-repo-transfer branch from 35a2ae1 to df565d4 Compare January 26, 2020 17:49

zeripath changed the title ~~API endpint for repo transfer~~ API endpoint for repo transfer Jan 26, 2020

zeripath reviewed Jan 26, 2020

View reviewed changes

routers/api/v1/repo/repo.go Outdated Show resolved Hide resolved

zeripath approved these changes Jan 26, 2020

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2020

zeripath approved these changes Jan 26, 2020

View reviewed changes

6543 force-pushed the api-repo-transfer branch from db960df to da4a318 Compare January 27, 2020 05:18

lunny requested changes Jan 28, 2020

View reviewed changes

6543 changed the title ~~API endpoint for repo transfer~~ WIP: API endpoint for repo transfer Jan 28, 2020

6543 force-pushed the api-repo-transfer branch 2 times, most recently from 66cf951 to 84e5454 Compare January 28, 2020 23:56

6543 mentioned this pull request Jan 29, 2020

Refactor api repo dir #10048

Merged

6543 changed the title ~~WIP: API endpoint for repo transfer~~ API endpoint for repo transfer Jan 29, 2020

6543 requested a review from lunny January 29, 2020 00:24

lunny reviewed Jan 31, 2020

View reviewed changes

routers/api/v1/repo/transfer.go Outdated Show resolved Hide resolved

lunny approved these changes Jan 31, 2020

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2020

6543 added 4 commits January 31, 2020 04:44

squash

f7e56ce

optimize

bcec687

fail before make any changes

52324a2

fix-header

a2002d2

6543 force-pushed the api-repo-transfer branch from 2e2c0d5 to a2002d2 Compare January 31, 2020 03:44

Merge branch 'master' into api-repo-transfer

cfa9dfd

Merge branch 'master' into api-repo-transfer

b64626b

zeripath merged commit 13bc820 into go-gitea:master Jan 31, 2020

6543 deleted the api-repo-transfer branch January 31, 2020 15:50

jolheiser mentioned this pull request Feb 26, 2020

Transfer ownsership via json api #5075

Closed

hrvoj3e mentioned this pull request Feb 27, 2020

getting error 500 when trying to transfer repo from user to organization #10230

Closed

7 tasks

zeripath mentioned this pull request May 17, 2020

Changelog for v1.12.0-rc1 #11462

Merged

zeripath changed the title ~~API endpoint for repo transfer~~ Add API endpoint for repo transfer May 17, 2020

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add API endpoint for repo transfer #9947

Add API endpoint for repo transfer #9947

6543 commented Jan 23, 2020 •

edited

Loading

codecov-io commented Jan 23, 2020 •

edited

Loading

6543 commented Jan 25, 2020

6543 commented Jan 26, 2020

6543 commented Jan 26, 2020

6543 commented Jan 26, 2020

zeripath left a comment

6543 commented Jan 26, 2020

lunny commented Jan 27, 2020

6543 commented Jan 27, 2020

camlafit commented Jan 27, 2020

lunny Jan 28, 2020

6543 commented Jan 29, 2020 •

edited

Loading

6543 commented Jan 29, 2020

6543 commented Jan 29, 2020

6543 commented Jan 30, 2020

6543 commented Jan 31, 2020

Add API endpoint for repo transfer #9947

Add API endpoint for repo transfer #9947

Conversation

6543 commented Jan 23, 2020 • edited Loading

codecov-io commented Jan 23, 2020 • edited Loading

Codecov Report

6543 commented Jan 25, 2020

6543 commented Jan 26, 2020

6543 commented Jan 26, 2020

6543 commented Jan 26, 2020

zeripath left a comment

Choose a reason for hiding this comment

6543 commented Jan 26, 2020

lunny commented Jan 27, 2020

6543 commented Jan 27, 2020

camlafit commented Jan 27, 2020

lunny Jan 28, 2020

Choose a reason for hiding this comment

6543 commented Jan 29, 2020 • edited Loading

6543 commented Jan 29, 2020

6543 commented Jan 29, 2020

6543 commented Jan 30, 2020

6543 commented Jan 31, 2020

6543 commented Jan 23, 2020 •

edited

Loading

codecov-io commented Jan 23, 2020 •

edited

Loading

6543 commented Jan 29, 2020 •

edited

Loading