Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix org hooks template error bugs caused by #3929 #3999

Merged
merged 3 commits into from
May 23, 2018
Merged

fix org hooks template error bugs caused by #3929 #3999

merged 3 commits into from
May 23, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented May 21, 2018

No description provided.

@lunny lunny added the type/bug label May 21, 2018
@lunny lunny added this to the 1.5.0 milestone May 21, 2018
@codecov-io
Copy link

codecov-io commented May 21, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@71a8fe3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3999   +/-   ##
=========================================
  Coverage          ?   20.05%           
=========================================
  Files             ?      153           
  Lines             ?    30347           
  Branches          ?        0           
=========================================
  Hits              ?     6086           
  Misses            ?    23348           
  Partials          ?      913
Impacted Files Coverage Δ
routers/repo/webhook.go 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a8fe3...2cf55b4. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2018
@lunny lunny merged commit 60d95a0 into go-gitea:master May 23, 2018
@lunny lunny deleted the lunny/fix_org_hooks_tmpl branch May 23, 2018 07:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @appleboy @lafriks @bkcsoft