Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn users about *every* dirty form #3707

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Don't warn users about *every* dirty form #3707

merged 1 commit into from
Mar 23, 2018

Conversation

Treora
Copy link
Contributor

@Treora Treora commented Mar 22, 2018

The choice regarding which forms should or should not trigger a warning
is subjective. I tried to be consistent and not warn about forms that:

  • run an action, rather than edit data: search, send an email.
  • delete data: a warning about losing data would be confusing

Note that forms on sign-in pages were already ignored (using a selector,
rather than an explicit class on the form element).

Fixes #3698.

Note: I did not yet manage to build gitea (due to some problem with golang), so I have not been able to test this change properly

The choice regarding which forms should or should not trigger a warning
is subjective. I tried to be consistent and not warn about forms that:
 - run an action, rather than edit data: search, send an email.
 - delete data: a warning about losing data would be confusing

Note that forms on sign-in pages were already ignored (using a selector,
rather than an explicit class on the form element).

Fixes #3698.
@codecov-io
Copy link

Codecov Report

Merging #3707 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3707      +/-   ##
==========================================
+ Coverage   35.79%   35.79%   +<.01%     
==========================================
  Files         287      287              
  Lines       41496    41496              
==========================================
+ Hits        14854    14855       +1     
  Misses      24454    24454              
+ Partials     2188     2187       -1
Impacted Files Coverage Δ
models/repo_list.go 56.37% <0%> (-1.35%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64aa18...1c3914f. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2018
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Mar 22, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2018
@lafriks
Copy link
Member

lafriks commented Mar 23, 2018

@thehowl ~~~your suggestion does not help much ;)~~~

@thehowl
Copy link
Contributor

thehowl commented Mar 23, 2018

@lafriks someone's pulling a prank on me, it seems (that's thehowi, not thehowl). Whatever twisted mind thought of that...

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2018
@lunny lunny added this to the 1.5.0 milestone Mar 23, 2018
@lunny lunny merged commit 2dc6f15 into go-gitea:master Mar 23, 2018
@Treora Treora deleted the fewer-form-warnings branch March 23, 2018 17:24
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Are you sure you want to leave?" is asked even for search queries
7 participants