Improve issue & code search #33860
Merged
Improve issue & code search #33860
+315
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
wxiaoguang
force-pushed
the
refactor-search-engine
branch
2 times, most recently
from
ee59dd5 to
6127b4d
Compare
wxiaoguang
force-pushed
the
refactor-search-engine
branch
2 times, most recently
from
b50e754 to
4346249
Compare
wxiaoguang
added
the
type/refactoring
|
|
wxiaoguang
force-pushed
the
refactor-search-engine
branch
2 times, most recently
from
2d77e13 to
3de2208
Compare
wxiaoguang
force-pushed
the
refactor-search-engine
branch
from
3de2208 to
ad14b12
Compare
|
Hi, It looks good overall. However, the user might not want to deal with complicated mode selection, I would like the UI to be similar to grep.app or sourcegraph, which would make it closer to the search experience in IDEs like in vscode. https://grep.app/search?q=make+func 
https://sourcegraph.com/search?q=context:global+make+func&patternType=keyword&sm=0 
|
This is only a refactoring PR to fix existing problems. New PRs could have new UI. |
|
And actually that dropdown matches your screenshot:
|
wxiaoguang
force-pushed
the
refactor-search-engine
branch
2 times, most recently
from
ce45b7c to
fa4beda
Compare
wxiaoguang
force-pushed
the
refactor-search-engine
branch
from
fa4beda to
0d9f336
Compare
lunny
approved these changes
Mar 12, 2025
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Mar 13, 2025
GiteaBot
added
lgtm/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each "indexer" should provide the "search modes" they support by themselves. And we need to remove the "fuzzy" search for code.