Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove context from git struct #33793

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Remove context from git struct #33793

merged 6 commits into from
Mar 4, 2025

Conversation

TheFox0x7
Copy link
Contributor

No major change.
Argument is moved from struct init in command run, which lets us remove context from struct.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 4, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/migrations and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@wxiaoguang
Copy link
Contributor

Some tests fail during test (maybe some "ctx" change was missing)

@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 4, 2025
@TheFox0x7
Copy link
Contributor Author

Yeah, it was behind race compile tag so lsp and regular tests did not catch it.

lunny
lunny reviewed Mar 4, 2025
View reviewed changes
lunny
lunny reviewed Mar 4, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 4, 2025
@lunny lunny merged commit ae3a18e into go-gitea:main Mar 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 5, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1f845db 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade golang net from 0.35.0 -> 0.36.0 (go-gitea#33795)
  Remove context from git struct (go-gitea#33793)
  Small refactor to reduce unnecessary database queries and remove duplicated functions (go-gitea#33779)
  Refactor repo-issue.ts (go-gitea#33784)
  Refactor repo-settings.ts (go-gitea#33785)
  Refactor admin/common.ts (go-gitea#33788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/migrations size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TheFox0x7 @wxiaoguang @lunny @GiteaBot