Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade go-crypto from 1.1.4 to 1.1.6 (#33745) #33754

Merged
merged 4 commits into from
Mar 1, 2025
Merged

upgrade go-crypto from 1.1.4 to 1.1.6 (#33745) #33754

merged 4 commits into from
Mar 1, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 28, 2025

Fix #33296
Backport #33745

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2025
@GiteaBot GiteaBot added this to the 1.23.5 milestone Feb 28, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2025
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2025
@lunny lunny force-pushed the lunny/upgrade_crypto2 branch from baeb3f6 to 70a489f Compare March 1, 2025 06:25
@lunny lunny changed the title upgrade go-crypto from 1.1.5 to 1.1.6 (#33745) upgrade go-crypto from 1.1.4 to 1.1.6 (#33745) Mar 1, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2025
@silverwind
Copy link
Member

This compile: version "go1.23.6" does not match go tool version "go1.23.0" seems related to #33727 (comment).

If it indeed is the culprit, I have no idea how to solve because go mod tidy automatically introduces this go 1.23.0 string every time it runs.

@silverwind
Copy link
Member

silverwind commented Mar 1, 2025 •
edited
Loading

This compile: version "go1.23.6" does not match go tool version "go1.23.0" seems related to #33727 (comment).

If it indeed is the culprit, I have no idea how to solve because go mod tidy automatically introduces this go 1.23.0 string every time it runs.

At this point, I'd call this a bug in golang with no workaround available except disabling the tidy check, follow these:

golang/go#62278
golang/go#65847

@wxiaoguang wxiaoguang force-pushed the lunny/upgrade_crypto2 branch from 729c3cc to cfda3fa Compare March 1, 2025 11:05
@wxiaoguang wxiaoguang force-pushed the lunny/upgrade_crypto2 branch from cfda3fa to c0ad7e4 Compare March 1, 2025 11:14
@wxiaoguang wxiaoguang force-pushed the lunny/upgrade_crypto2 branch from 57ea74c to 29d036a Compare March 1, 2025 12:01
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2025
@wxiaoguang wxiaoguang force-pushed the lunny/upgrade_crypto2 branch from a77cb9d to b26520a Compare March 1, 2025 12:10
@techknowlogick techknowlogick enabled auto-merge (squash) March 1, 2025 14:23
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2025
@techknowlogick techknowlogick merged commit 7307422 into go-gitea:release/v1.23 Mar 1, 2025
26 checks passed
@lunny lunny deleted the lunny/upgrade_crypto2 branch March 1, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/internal size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.5
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @silverwind @techknowlogick @GiteaBot @wxiaoguang