Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused variable on makefile #2225

Merged
merged 1 commit into from
Jul 29, 2017
Merged

remove unused variable on makefile #2225

merged 1 commit into from
Jul 29, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 28, 2017

follow @philfry 's advice on #2194

@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 28, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 28, 2017
@Bwko
Copy link
Member

Bwko commented Jul 28, 2017

LGTM

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 28, 2017
@lafriks
Copy link
Member

lafriks commented Jul 29, 2017

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2017
@lafriks lafriks merged commit a9cc538 into go-gitea:master Jul 29, 2017
@lunny lunny deleted the lunny/remove_unused_variable_on_make branch July 29, 2017 09:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @Bwko @lafriks @bkcsoft