Fix GET /users/:username/repos endpoint

[ethantkoenig]

Fixes the following bugs in the GET /users/:username/repos endpoint:

• Used to get 500 if user was unauthenticated
• Used to indicate that requester has owner-level access of repos owned by :username, regardless of whether this was actually true
• Used to display the repositories that the authenticated user (not the searched user) had access to. Ideally, it should display neither, but like Github only display repos that the searched user owns.

Also improve existing integration tests to check that responses are expected.

[awwalker]

Is it not possible to combine these like they were before with an explicit check for ctx.User being equal to the user passed in? And only when they are equal displaying accessibleRepos as well as ownRepos? It feels like theres a lot of recycled code...

[ethantkoenig]

@awwalker No, because GET /users/:username/repos should not return accessible repos, even if you search for yourself. Accessible repos should only be returned by the GET /user/repos endpoint. We'll still be able to share the code in listUserRepos(..) between the GET /users/:username/repos and GET orgs/:orgname/repos endpoints.

[awwalker]

@ethantkoenig Hm ok I am confused as to why not then. Can you explain please?

[ethantkoenig]

@awwalker The canned answer: because that's how Github's API is, and we try to match the Github API as closely as possible

My longer answer: which seems like a cleaner and more concise specification?

1. GET /users/:username/repos: Returns the repos that :username owns
2. GET /users/:username/repos: Returns the repos that :username owns. In (only) the case where the requester is authenticated as :username, the repos that :username does not own but has access to are also included

There is already an endpoint for listing the repos that you have access to (GET /user/repos), so we should avoid unnecessarily complicating the behavior of the GET /users/:username/repos endpoint.

[awwalker]

@ethantkoenig Awesome. Thanks for going above the canned response! And I see how this is still usable for orgs.

[sapk]

With a quick overview and addition of tests I trust you for LGTM.

[lunny]

LGTM

[Morlinest]

You can't use un-exported values in decode function.