Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wiki preview links #2119

Merged
merged 3 commits into from
Jul 7, 2017
Merged

Fix wiki preview links #2119

merged 3 commits into from
Jul 7, 2017

Conversation

ethantkoenig
Copy link
Member

Fixes #1900, which was caused by a bug in markdown.URLJoin(..). I've also added unit tests for markdown.URLJoin(..).

@lunny lunny added the type/bug label Jul 7, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 7, 2017
@lafriks
Copy link
Member

lafriks commented Jul 7, 2017 •
edited
Loading

Why did all resulting test urls change?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2017
@ethantkoenig
Copy link
Member Author

@lafriks The old tests were broken. The expected strings were of the form .../rawimage/foo.png instead of .../raw/image/foo.png. And before URLJoin(..) was fixed, the actual strings were similarly wrong (which is why tests had been passing)

@lafriks
Copy link
Member

lafriks commented Jul 7, 2017

Ok, than it LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 7, 2017
@sapk
Copy link
Member

sapk commented Jul 7, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2017
@andreynering andreynering merged commit 5651cc7 into go-gitea:master Jul 7, 2017
@ethantkoenig ethantkoenig deleted the fix/wiki branch July 7, 2017 15:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Links broken in Wiki page preview
6 participants
@ethantkoenig @lafriks @sapk @lunny @tboerger @andreynering