Add integration test for file editing #1907
Conversation
typeless
force-pushed
the
add-integration-test-for-edit-file
branch
2 times, most recently
from
3cca1c4 to
a436302
Compare
|
LGTM |
tboerger
added
the
lgtm/need 2
integrations/editor_test.go
Outdated
| @@ -104,3 +106,55 @@ func TestCreateFileOnProtectedBranch(t *testing.T) { | |||
| // Check body for error message | |||
| assert.Contains(t, string(resp.Body), "Can not commit to protected branch 'master'.") | |||
| } | |||
|
|
|||
| func testEditFile(t *testing.T, session *TestSession, urlstr string) { | |||
There was a problem hiding this comment.
I would rather change this to owner, repo, branch, filePath, content string TBH
There was a problem hiding this comment.
I thought of that at first but another side of me told that function parameters should no more than 4 if possible otherwise it would look awkward. I will reconsider your advice or if anybody else there is willing to chime in? I don't strongly insist on either way but I'd like to have more confirmations.
There was a problem hiding this comment.
As it can simplify the code handling the arguments, I am now inclined to agree with you.
integrations/editor_test.go
Outdated
| func TestEditFile(t *testing.T) { | ||
| prepareTestEnv(t) | ||
| session := loginUser(t, "user2", "password") | ||
| testEditFile(t, session, "/user2/repo1/master/README.md") |
There was a problem hiding this comment.
Please also check if the user:
- can edit a collaborating repo. (user does not own, but can push)
- can not edit a repo that they don't have push-right to.
- can not edit a protected branch
🙂
There was a problem hiding this comment.
My plan was to have this as a stepstone for the pull-merge testing (#641). I'd like to leave those further works to other PRs if needed.
There was a problem hiding this comment.
There is integration test for editing file in protected branch. I added it when fixing bug that did allow edit files on protected branch :)
typeless
force-pushed
the
add-integration-test-for-edit-file
branch
from
a436302 to
fb68890
Compare
|
LGTM |
tboerger
added
lgtm/done
No description provided.