Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR template error #1834

Merged
merged 1 commit into from
May 30, 2017
Merged

Fix PR template error #1834

merged 1 commit into from
May 30, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented May 29, 2017 •
edited
Loading

Fixes #1542. Ensures that PullRequestCtx.BaseRepo is populated when a fork's parent does not accept pull requests (since the fork should support intra-repo pull requests).

To reproduce the bug that this fixes, do the following:

  1. Create a mirror repo (call it repo1)
  2. Create a fork of repo1 (call it repo2)
  3. Create a fork of repo2 (call it repo3)
  4. Visit /:username/repo2/pulls, and you should get the error described in Template error listing pull requests #1542.

If you follow the above steps with my changes, you should get no such error.

@lunny lunny added this to the 1.2.0 milestone May 30, 2017
@lunny lunny added the type/bug label May 30, 2017
@lunny
Copy link
Member

lunny commented May 30, 2017

PR lit page integration tests is really needed.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2017
@sapk
Copy link
Member

sapk commented May 30, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2017
@appleboy appleboy merged commit 642f844 into go-gitea:master May 30, 2017
@ethantkoenig ethantkoenig deleted the fix_pull_template branch May 30, 2017 12:48
@bkcsoft
Copy link
Member

bkcsoft commented Jun 12, 2017

Since this breaks things, should we not backport this? @go-gitea/owners @go-gitea/advisors

@ethantkoenig
Copy link
Member Author

@bkcsoft What does this break?

@bkcsoft
Copy link
Member

bkcsoft commented Jun 12, 2017

@ethantkoenig sorry, it fixes a vital bug is what I meant 😉

@tuxillo
Copy link
Contributor

tuxillo commented Jun 18, 2017

Hi,

Would it be possible to have this one on a (possible?) upcoming 1.1.3 tag?

Thanks,
Antonio Huete

@lunny
Copy link
Member

lunny commented Jun 19, 2017

@ethantkoenig maybe send a backport PR is good.

@ethantkoenig ethantkoenig restored the fix_pull_template branch June 19, 2017 02:00
@ethantkoenig ethantkoenig mentioned this pull request Jun 19, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jun 19, 2017
@ethantkoenig ethantkoenig deleted the fix_pull_template branch December 18, 2017 06:06
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Template error listing pull requests
7 participants
@ethantkoenig @lunny @sapk @appleboy @bkcsoft @tuxillo @tboerger